Revert "Safely import optional python packages (#13936)" #14197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e04ee42. Signed-off-by: Charlie Truong <chtruong@nvidia.com>
|
Verified that this fixes the failing test after manually running this on a CI machine. Moving forward with the revert to unblock other PRs. I think I know the issue and will open a new PR with a fix. |
chtruong814
added a commit
that referenced
this pull request
Jul 11, 2025
chtruong814
added a commit
that referenced
this pull request
Jul 11, 2025
* Revert "Revert "Safely import optional python packages (#13936)" (#14197)" This reverts commit 808845b. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix LocalCheckpointCallback safe import Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Jul 23, 2025
…VIDIA-NeMo#14197) This reverts commit e04ee42. Signed-off-by: Charlie Truong <chtruong@nvidia.com> Co-authored-by: Robert Clark <roclark@users.noreply.github.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Jul 23, 2025
…DIA-NeMo#14198) * Revert "Revert "Safely import optional python packages (NVIDIA-NeMo#13936)" (NVIDIA-NeMo#14197)" This reverts commit 808845b. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix LocalCheckpointCallback safe import Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
monica-sekoyan
pushed a commit
that referenced
this pull request
Aug 4, 2025
monica-sekoyan
pushed a commit
that referenced
this pull request
Aug 4, 2025
* Revert "Revert "Safely import optional python packages (#13936)" (#14197)" This reverts commit 808845b. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix LocalCheckpointCallback safe import Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
…VIDIA-NeMo#14197) This reverts commit e04ee42. Signed-off-by: Charlie Truong <chtruong@nvidia.com> Co-authored-by: Robert Clark <roclark@users.noreply.github.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
…DIA-NeMo#14198) * Revert "Revert "Safely import optional python packages (NVIDIA-NeMo#13936)" (NVIDIA-NeMo#14197)" This reverts commit 808845b. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix LocalCheckpointCallback safe import Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
…VIDIA-NeMo#14197) This reverts commit e04ee42. Signed-off-by: Charlie Truong <chtruong@nvidia.com> Co-authored-by: Robert Clark <roclark@users.noreply.github.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
…DIA-NeMo#14198) * Revert "Revert "Safely import optional python packages (NVIDIA-NeMo#13936)" (NVIDIA-NeMo#14197)" This reverts commit 808845b. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix LocalCheckpointCallback safe import Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
…VIDIA-NeMo#14197) This reverts commit e04ee42. Signed-off-by: Charlie Truong <chtruong@nvidia.com> Co-authored-by: Robert Clark <roclark@users.noreply.github.com>
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
…DIA-NeMo#14198) * Revert "Revert "Safely import optional python packages (NVIDIA-NeMo#13936)" (NVIDIA-NeMo#14197)" This reverts commit 808845b. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix LocalCheckpointCallback safe import Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com>
guyueh1
pushed a commit
to guyueh1/NeMo
that referenced
this pull request
Aug 25, 2025
…VIDIA-NeMo#14197) This reverts commit e04ee42. Signed-off-by: Charlie Truong <chtruong@nvidia.com> Co-authored-by: Robert Clark <roclark@users.noreply.github.com> Signed-off-by: Guyue Huang <guyueh@nvidia.com>
guyueh1
pushed a commit
to guyueh1/NeMo
that referenced
this pull request
Aug 25, 2025
…DIA-NeMo#14198) * Revert "Revert "Safely import optional python packages (NVIDIA-NeMo#13936)" (NVIDIA-NeMo#14197)" This reverts commit 808845b. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix LocalCheckpointCallback safe import Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e04ee42.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Revert "Safely import optional python packages (#13936)"
This was able to merge without the CI running. And it seems some failures are happening on subsequent tests:
https://github.com/NVIDIA/NeMo/actions/runs/16218093086/job/45792718838
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information