KEMBAR78
fix speechlm lhotse loading nemo_tarred by stevehuang52 · Pull Request #14314 · NVIDIA-NeMo/NeMo · GitHub
Skip to content

Conversation

@stevehuang52
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Fix loading nemo_tarred in when text_field doesn't match with answer_key

Collection: [speechlm]

Signed-off-by: stevehuang52 <heh@nvidia.com>
Copy link
Collaborator

@weiqingw4ng weiqingw4ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@github-actions github-actions bot removed the Run CICD label Jul 23, 2025
@github-actions
Copy link
Contributor

[🤖]: Hi @stevehuang52 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@stevehuang52 stevehuang52 merged commit 6437716 into main Jul 23, 2025
157 of 166 checks passed
@stevehuang52 stevehuang52 deleted the heh/fix_speechlm_data branch July 23, 2025 19:52
monica-sekoyan pushed a commit that referenced this pull request Aug 4, 2025
Signed-off-by: stevehuang52 <heh@nvidia.com>
nasretdinovr pushed a commit to nasretdinovr/NeMo that referenced this pull request Aug 8, 2025
Signed-off-by: stevehuang52 <heh@nvidia.com>
guyueh1 pushed a commit to guyueh1/NeMo that referenced this pull request Aug 25, 2025
Signed-off-by: stevehuang52 <heh@nvidia.com>
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants