KEMBAR78
Hyena support for flash decode API by jstjohn · Pull Request #14315 · NVIDIA-NeMo/NeMo · GitHub
Skip to content

Conversation

@jstjohn
Copy link
Collaborator

@jstjohn jstjohn commented Jul 23, 2025

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

jstjohn added 3 commits July 23, 2025 00:00
…gatron

Signed-off-by: John St John <jstjohn@nvidia.com>
…odel

Signed-off-by: John St John <jstjohn@nvidia.com>
…te-forward-inf

Signed-off-by: John St John <jstjohn@nvidia.com>
@jstjohn jstjohn requested a review from JRD971000 July 23, 2025 20:36
Signed-off-by: John St John <jstjohn@nvidia.com>
@jstjohn jstjohn self-assigned this Jul 24, 2025
@jstjohn jstjohn added Run CICD feature request/PR for a new feature labels Jul 24, 2025
@github-actions github-actions bot removed the Run CICD label Jul 25, 2025
@github-actions
Copy link
Contributor

[🤖]: Hi @jstjohn 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@jstjohn jstjohn enabled auto-merge (squash) July 25, 2025 16:13
JRD971000
JRD971000 previously approved these changes Jul 28, 2025
Copy link
Collaborator

@JRD971000 JRD971000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks John!

Signed-off-by: John St John <jstjohn@nvidia.com>
jstjohn added a commit to NVIDIA/bionemo-framework that referenced this pull request Jul 29, 2025
…tween inputs/embeddings, will be merged to nemo in NVIDIA-NeMo/NeMo#14315

Signed-off-by: John St John <jstjohn@nvidia.com>
@github-actions
Copy link
Contributor

[🤖]: Hi @jstjohn 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@github-actions github-actions bot removed the Run CICD label Jul 30, 2025
@jstjohn jstjohn merged commit b97e42b into main Jul 30, 2025
225 checks passed
@jstjohn jstjohn deleted the jstjohn/hyena-update-forward-inf branch July 30, 2025 08:17
github-merge-queue bot pushed a commit to NVIDIA/bionemo-framework that referenced this pull request Jul 31, 2025
### Description
- Support for Flash Decode
- Do not yet support cudagraph.

Depends on NeMo PR: NVIDIA-NeMo/NeMo#14315

---------

Signed-off-by: John St John <jstjohn@nvidia.com>
nasretdinovr pushed a commit to nasretdinovr/NeMo that referenced this pull request Aug 8, 2025
* Adding updates to hyena forward pass that reflect newer changes to megatron

Signed-off-by: John St John <jstjohn@nvidia.com>

* Make it so recompute num layers do not need to be a multiple of the model

Signed-off-by: John St John <jstjohn@nvidia.com>

* Update formatting and change grad context for inference time

Signed-off-by: John St John <jstjohn@nvidia.com>

* Address pylint error

Signed-off-by: John St John <jstjohn@nvidia.com>

* Add ability to set the embedding/output weight sharing setting from the config

Signed-off-by: John St John <jstjohn@nvidia.com>

---------

Signed-off-by: John St John <jstjohn@nvidia.com>
guyueh1 pushed a commit to guyueh1/NeMo that referenced this pull request Aug 25, 2025
* Adding updates to hyena forward pass that reflect newer changes to megatron

Signed-off-by: John St John <jstjohn@nvidia.com>

* Make it so recompute num layers do not need to be a multiple of the model

Signed-off-by: John St John <jstjohn@nvidia.com>

* Update formatting and change grad context for inference time

Signed-off-by: John St John <jstjohn@nvidia.com>

* Address pylint error

Signed-off-by: John St John <jstjohn@nvidia.com>

* Add ability to set the embedding/output weight sharing setting from the config

Signed-off-by: John St John <jstjohn@nvidia.com>

---------

Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request/PR for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants