Add deprecation notice to eval code #14316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishree <abhishreetm@gmail.com>
marta-sd
reviewed
Jul 24, 2025
nemo/collections/llm/api.py
Outdated
| ): | ||
| warnings.warn( | ||
| "The 'deploy' function is deprecated and will be removed in NeMo FW 25.09 container release. " | ||
| "For evaluation functionality, please use the new Eval repository: https://github.com/NVIDIA/NeMo-Eval", |
There was a problem hiding this comment.
url should be: https://github.com/NVIDIA-NeMo/Eval
nemo/collections/llm/api.py
Outdated
| ) -> dict: | ||
| warnings.warn( | ||
| "The 'evaluate' function is deprecated and will be removed in NeMo FW 25.09 container release. " | ||
| "For evaluation functionality, please use the new Eval repository: https://github.com/NVIDIA/NeMo-Eval", |
There was a problem hiding this comment.
same here: https://github.com/NVIDIA-NeMo/Eval
scripts/llm/evaluation.py
Outdated
|
|
||
| warnings.warn( | ||
| "This evaluation script is deprecated and will be removed in NeMo FW 25.09 container release. " | ||
| "For evaluation functionality, please use the new Eval repository: https://github.com/NVIDIA/NeMo-Eval", |
There was a problem hiding this comment.
and here: https://github.com/NVIDIA-NeMo/Eval
ko3n1g
reviewed
Jul 24, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
ko3n1g
reviewed
Jul 24, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
ko3n1g
reviewed
Jul 24, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
ko3n1g
reviewed
Jul 24, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
ko3n1g
requested review from
chtruong814,
pablo-garay and
thomasdhc
as code owners
Signed-off-by: oliver könig <okoenig@nvidia.com>
ko3n1g
force-pushed
the
athitten/eval_deprecation_warning
branch
from
647b271 to
4314087
Compare
Signed-off-by: ko3n1g <ko3n1g@users.noreply.github.com>
|
LGTM, thanks! |
Signed-off-by: ko3n1g <ko3n1g@users.noreply.github.com>
…tion_warning Signed-off-by: oliver könig <okoenig@nvidia.com>
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
* Add deprecation notice to eval code Signed-off-by: Abhishree <abhishreetm@gmail.com> * Update nemo/collections/llm/api.py Signed-off-by: oliver könig <okoenig@nvidia.com> * Update nemo/collections/llm/api.py Signed-off-by: oliver könig <okoenig@nvidia.com> * Update scripts/llm/evaluation.py Signed-off-by: oliver könig <okoenig@nvidia.com> * Update scripts/llm/evaluation.py Signed-off-by: oliver könig <okoenig@nvidia.com> * deprecate export-deploy as well Signed-off-by: oliver könig <okoenig@nvidia.com> * Apply isort and black reformatting Signed-off-by: ko3n1g <ko3n1g@users.noreply.github.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * Apply isort and black reformatting Signed-off-by: ko3n1g <ko3n1g@users.noreply.github.com> --------- Signed-off-by: Abhishree <abhishreetm@gmail.com> Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: ko3n1g <ko3n1g@users.noreply.github.com> Co-authored-by: oliver könig <okoenig@nvidia.com> Co-authored-by: ko3n1g <ko3n1g@users.noreply.github.com>
guyueh1
pushed a commit
to guyueh1/NeMo
that referenced
this pull request
Aug 25, 2025
* Add deprecation notice to eval code Signed-off-by: Abhishree <abhishreetm@gmail.com> * Update nemo/collections/llm/api.py Signed-off-by: oliver könig <okoenig@nvidia.com> * Update nemo/collections/llm/api.py Signed-off-by: oliver könig <okoenig@nvidia.com> * Update scripts/llm/evaluation.py Signed-off-by: oliver könig <okoenig@nvidia.com> * Update scripts/llm/evaluation.py Signed-off-by: oliver könig <okoenig@nvidia.com> * deprecate export-deploy as well Signed-off-by: oliver könig <okoenig@nvidia.com> * Apply isort and black reformatting Signed-off-by: ko3n1g <ko3n1g@users.noreply.github.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * Apply isort and black reformatting Signed-off-by: ko3n1g <ko3n1g@users.noreply.github.com> --------- Signed-off-by: Abhishree <abhishreetm@gmail.com> Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: ko3n1g <ko3n1g@users.noreply.github.com> Co-authored-by: oliver könig <okoenig@nvidia.com> Co-authored-by: ko3n1g <ko3n1g@users.noreply.github.com> Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information