Fix Gemma2/3 & Llava (Next) & Llama4 conversion issue with latest transformers #14367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…formers Signed-off-by: Ao Tang <aot@nvidia.com>
suiyoubi
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Ao Tang <aot@nvidia.com>
suiyoubi
force-pushed
the
aot/cicd-conversion-fix
branch
from
3a47405 to
f2593b1
Compare
Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>
Signed-off-by: Ao Tang <aot@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Ao Tang <aot@nvidia.com>
suiyoubi
changed the title
ko3n1g
approved these changes
Jul 31, 2025
|
Nemo2 tests are passing, speech are known flaky |
orena1
pushed a commit
to orena1/NeMo
that referenced
this pull request
Aug 7, 2025
…nsformers (NVIDIA-NeMo#14367) * Fix Gemma3VL & Llava Next & Llama4 conversion issue when latest transformers Signed-off-by: Ao Tang <aot@nvidia.com> * bump transformers Signed-off-by: Ao Tang <aot@nvidia.com> * Apply isort and black reformatting Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com> * Remove unused import of Gemma3Model in gemma3vl.py Signed-off-by: Ao Tang <aot@nvidia.com> * build: Lift upper boundary of transformers Signed-off-by: oliver könig <okoenig@nvidia.com> * Fix key check Signed-off-by: Ao Tang <aot@nvidia.com> --------- Signed-off-by: Ao Tang <aot@nvidia.com> Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com> Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: suiyoubi <suiyoubi@users.noreply.github.com> Co-authored-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Oren Amsalem <oren.a4@gmail.com>
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
…nsformers (NVIDIA-NeMo#14367) * Fix Gemma3VL & Llava Next & Llama4 conversion issue when latest transformers Signed-off-by: Ao Tang <aot@nvidia.com> * bump transformers Signed-off-by: Ao Tang <aot@nvidia.com> * Apply isort and black reformatting Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com> * Remove unused import of Gemma3Model in gemma3vl.py Signed-off-by: Ao Tang <aot@nvidia.com> * build: Lift upper boundary of transformers Signed-off-by: oliver könig <okoenig@nvidia.com> * Fix key check Signed-off-by: Ao Tang <aot@nvidia.com> --------- Signed-off-by: Ao Tang <aot@nvidia.com> Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com> Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: suiyoubi <suiyoubi@users.noreply.github.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
guyueh1
pushed a commit
to guyueh1/NeMo
that referenced
this pull request
Aug 25, 2025
…nsformers (NVIDIA-NeMo#14367) * Fix Gemma3VL & Llava Next & Llama4 conversion issue when latest transformers Signed-off-by: Ao Tang <aot@nvidia.com> * bump transformers Signed-off-by: Ao Tang <aot@nvidia.com> * Apply isort and black reformatting Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com> * Remove unused import of Gemma3Model in gemma3vl.py Signed-off-by: Ao Tang <aot@nvidia.com> * build: Lift upper boundary of transformers Signed-off-by: oliver könig <okoenig@nvidia.com> * Fix key check Signed-off-by: Ao Tang <aot@nvidia.com> --------- Signed-off-by: Ao Tang <aot@nvidia.com> Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com> Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: suiyoubi <suiyoubi@users.noreply.github.com> Co-authored-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…formers
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information