KEMBAR78
Making ODataQueryOptions.GetNextPageLink public. by brjohnstmsft · Pull Request #384 · OData/WebApi · GitHub
Skip to content

Conversation

@brjohnstmsft
Copy link
Contributor

This will be useful for anyone processing OData query options directly (i.e. -- not using LINQ and ApplyTo()).

…for anyone processing OData query options directly (i.e. -- not using LINQ and ApplyTo()).
@msftclas
Copy link

msftclas commented Jun 8, 2015

Hi @brjohnstmsft, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@brjohnstmsft
Copy link
Contributor Author

This is for this issue: #377

@congysu
Copy link
Contributor

congysu commented Jun 9, 2015

Thanks @brjohnstmsft for sending a pull request :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brjohnstmsft. We need to check if the request is not null, and also the request.RequestUri is not null etc. for a public API; and add a few test cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok; working on it now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@VikingsFan
Copy link
Contributor

Thanks for your pull request! Squash those two commits as one will be better :) ,merged 604b16c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants