-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[API compatibility] update paddle divide divide_ add div div_ true_divide API #74562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name参数都统一放到最后面,避免name参数处于参数列表的任意位置
- 已知共性问题:类型提升/二元支持scalar,目前不用单API中修改,paconvert也可注释不执行,这个会后续统一支持。如果这里的除法操作的类型调整,不是共性问题,就可以新增相应的逻辑。
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (38.63%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #74562 +/- ##
==========================================
Coverage ? 38.63%
==========================================
Files ? 3
Lines ? 44
Branches ? 0
==========================================
Hits ? 17
Misses ? 27
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/re-run all-failed |
|
/re-run all-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…vide API (PaddlePaddle#74562) * [API compatibility] update paddle divide divide_ add div div_ true_divide api * update * test * update * update * update
PR Category
User Experience
PR Types
New features
Description
rounding_mode参数:支持None、'trunc'、'floor'三种类型的设置,其中'trunc' 为向0取整,'floor'为向负无穷取整;None时
相当于true_divide。
注:
pcard-67164