-
Notifications
You must be signed in to change notification settings - Fork 8k
Revert change to use BinaryFormatter for Out-GridView
#20300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
BinaryFormatter will removed from .Net 9.0 at all. So maybe revert only for release branch 7.4 and implement full fix for master branch? |
|
@iSazonov yes, we have more time with 7.5 to change the design to not rely on BinaryFormatter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. Left 1 comment.
...crosoft.Management.UI.Internal/ManagementList/FilterCore/FilterRules/FilterRuleExtensions.cs
Outdated
Show resolved
Hide resolved
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
Have we a tracking issue for follow work? |
PR Summary
Revert #20050
Out-GridViewwas designed around using theBinaryFormatterto make deep copies of Filters. When we removed usage of that type, we inadvertently broke filtering (althoughcontainsfilter still worked, but only that one). This change reverts the specific removal of use ofBinaryFormatterforOut-GridViewto bring back the previous functionality. The previous change to aClone()method was removed as it was incomplete.Manually tested each filter and duplicate filters.
PR Context
Fix #20223
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).