-
Notifications
You must be signed in to change notification settings - Fork 8k
Handle type inference for redirected commands #21131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle type inference for redirected commands #21131
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| $ExpectedTypeNames = @( | ||
| [PSDriveInfo].FullName | ||
| [VerboseRecord].FullName | ||
| [WarningRecord].FullName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add more tests to cover all branches in switch (line 1313.)
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
📣 Hey @MartinGC94, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
PR Summary
Updates the type inference for commands to also take stream redirections into account, both when redirecting the success stream (meaning it doesn't output anything) or when merging other streams (Error, Warning, etc.) into the success stream.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).