-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix Write-Host to respect OutputRendering = PlainText
#21188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Write-Host to respect OutputRendering = PlainText
#21188
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
📣 Hey @@SteveL-MSFT, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
PR Summary
Write-Hostavoids some of the existing checks forPSStyle.OutputRendering. So the change is in the internal host interface to not use the overloads for color whenOutputRenderingis explicitlyplaintext. Tested manually as redirection ofpwshgoes a different path and works as expected and the bug only shows up when writing directly to the console.PR Context
Fix #21168
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).