KEMBAR78
PMC parse state correctly from update command's response by anamnavi · Pull Request #24850 · PowerShell/PowerShell · GitHub
Skip to content

Conversation

@anamnavi
Copy link
Member

@anamnavi anamnavi commented Jan 23, 2025

PR Summary

Pipe response from PMC command to ConvertFrom-Json before accessing 'state' property and add logging.

This pull request includes changes to the Publish-PackageToPMC function in the .pipelines/EV2Specs/ServiceGroupRoot/Shell/Run/Run.ps1 file. The updates improve error handling and logging during the package publishing process.

Improvements to error handling and logging:

  • Changed the way the state of the update response is retrieved by using ConvertFrom-Json and added a verbose log for the state. This helps in better debugging and understanding the state of the response.
  • Added a verbose log for the publish response state and improved error messages for better clarity. This ensures that any issues during the publish process are clearly logged and easier to diagnose.

PR Context

PR Checklist

@anamnavi anamnavi changed the title Pmc state bugfix PMC parse state correctly from update command's response Jan 23, 2025
@TravisEz13
Copy link
Member

/azp run PowerShell-CI-macos, PowerShell-CI-Linux, PowerShell-CI-Windows, PSResourceGet ACR, PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13 TravisEz13 added BackPort-7.4.x-Consider BackPort-7.5.x-Consider CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Jan 23, 2025
@TravisEz13 TravisEz13 merged commit 251bf0d into PowerShell:master Jan 23, 2025
12 checks passed
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Jan 23, 2025

📣 Hey @anamnavi, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

TravisEz13 pushed a commit that referenced this pull request Jan 23, 2025
* Parse Json before accessing state property for PMC

* fix typo
TravisEz13 added a commit that referenced this pull request Jan 23, 2025
…4851)

* Parse Json before accessing state property for PMC

* fix typo

Co-authored-by: Anam Navied <anam.naviyou@gmail.com>
anamnavi added a commit to anamnavi/PowerShell that referenced this pull request Jan 23, 2025
…24850)

* Parse Json before accessing state property for PMC

* fix typo
anamnavi added a commit to anamnavi/PowerShell that referenced this pull request Jan 23, 2025
…24850)

* Parse Json before accessing state property for PMC

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BackPort-7.4.x-Done BackPort-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants