KEMBAR78
Fix GitHub Action filter overmatching by TravisEz13 · Pull Request #24929 · PowerShell/PowerShell · GitHub
Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Feb 3, 2025

PR Summary

This pull request includes changes to streamline and centralize the configuration for path filtering in GitHub Actions workflows. The most important changes involve the creation of a shared filter configuration file and the modification of multiple CI workflow files to use this shared configuration.

Centralization of path filters:

  • .github/action-filters.yml: Created a new file to define shared path filters for different components like github, tools, props, tests, mainSource, and buildModule.

Updates to CI workflows:

PR Context

The actions were overmatching after moving to dorny/paths-filters because it does a logical or of all filters including the not (!) statements.

PR Checklist

@TravisEz13 TravisEz13 changed the title List files which matched filter Fix GitHub Action filters Feb 3, 2025
@TravisEz13 TravisEz13 changed the title Fix GitHub Action filters Fix GitHub Action filter overmatching Feb 3, 2025
@TravisEz13 TravisEz13 marked this pull request as ready for review February 3, 2025 23:25
@TravisEz13 TravisEz13 added BackPort-7.4.x-Consider BackPort-7.5.x-Consider CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Feb 3, 2025
@TravisEz13 TravisEz13 merged commit 268c7f9 into master Feb 3, 2025
30 checks passed
@TravisEz13 TravisEz13 deleted the TravisEz13-patch-3 branch February 3, 2025 23:34
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Feb 3, 2025

📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BackPort-7.4.x-Done BackPort-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log MustHave

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants