KEMBAR78
Add default .NET install path for SDK validation by adityapatwardhan · Pull Request #25017 · PowerShell/PowerShell · GitHub
Skip to content

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Feb 14, 2025

PR Summary

This pull request includes an important change to the .pipelines/templates/release-validate-sdk.yml file to improve the reliability of locating the .NET SDK on Windows systems.

Changes to improve .NET SDK path detection:

  • .pipelines/templates/release-validate-sdk.yml: Added logic to check an additional possible location for the .NET SDK ($env:ProgramFiles\dotnet) on Windows systems before falling back to the existing path ($env:LocalAppData\Microsoft\dotnet). This change ensures that the script can find the .NET SDK even if it is installed in the default Program Files directory.

PR Context

PR Checklist

@adityapatwardhan adityapatwardhan requested a review from a team as a code owner February 14, 2025 18:19
@jshigetomi
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomi jshigetomi merged commit bc75960 into master Feb 14, 2025
36 checks passed
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Feb 14, 2025

📣 Hey @adityapatwardhan, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@TravisEz13 TravisEz13 deleted the fixSDKTests branch March 24, 2025 20:31
pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull request Apr 11, 2025
pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull request Apr 11, 2025
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants