KEMBAR78
Make Component Manifest Updater use neutral target in addition to RID target by TravisEz13 · Pull Request #25094 · PowerShell/PowerShell · GitHub
Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Feb 26, 2025

PR Summary

This pull request includes several changes to the Get-CGRegistrations function in the tools/findMissingNotices.ps1 file to improve the handling of target paths and to skip specific names during TPN (Third Party Notices) generation.

Improvements to target path handling:

  • Added a new variable $neutralTarget for each runtime pattern to handle neutral targets.
  • Updated the Get-ChildItem command to include items from the $neutralTarget path.

Enhancements to TPN generation:

  • Introduced a list of names to skip during TPN generation, stored in the $skipNames array.
  • Added logic to skip processing for names in the $skipNames array and included verbose logging for skipped names. [1] [2]

PR Context

.NET started using multiple targets in .NET 8. This makes this script miss some components.

PR Checklist

@TravisEz13
Copy link
Member Author

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TravisEz13 TravisEz13 enabled auto-merge (squash) February 26, 2025 17:40
@TravisEz13 TravisEz13 merged commit f467823 into PowerShell:master Feb 26, 2025
36 checks passed
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Feb 26, 2025

📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BackPort-7.4.x-Done BackPort-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants