KEMBAR78
Remove Az module installs and AzureRM uninstalls in pipeline by jshigetomi · Pull Request #25118 · PowerShell/PowerShell · GitHub
Skip to content

Remove Az module installs and AzureRM uninstalls in pipeline #25118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 11, 2025
Merged

Remove Az module installs and AzureRM uninstalls in pipeline #25118

merged 7 commits into from
Mar 11, 2025

Conversation

@jshigetomi
Copy link
Collaborator

@jshigetomi jshigetomi commented Mar 3, 2025 •
edited
Loading

PR Summary

This pull request includes several changes to various pipeline YAML files and the addition of a new PowerShell script. The changes mainly focus on modifying pipeline sources and removing unnecessary PowerShell module installation tasks.

Pipeline source updates:

  • Updated the source of CoOrdinatedBuildPipeline from 'PowerShell-Coordinated Packages-Official' to 'PowerShell-Coordinated Binaries-Official' in .pipelines/PowerShell-Packages-Official.yml [1] .pipelines/PowerShell-Release-Official-Azure.yml [2] and .pipelines/PowerShell-Release-Official.yml [3].

Removal of unnecessary tasks:

  • Removed the task to update the Az.Storage module in .pipelines/templates/checkAzureContainer.yml.
  • Removed the task to install PowerShell modules in .pipelines/templates/compliance/apiscan.yml.
  • Removed the task to install and uninstall PowerShell modules in .pipelines/templates/compliance/generateNotice.yml.
  • Removed the task to remove AzureRM modules and install Az.Storage in .pipelines/templates/release-MakeBlobPublic.yml [1] [2] .pipelines/templates/release-create-msix.yml [3] .pipelines/templates/release-upload-buildinfo.yml [4] .pipelines/templates/release-validate-packagenames.yml [5] and .pipelines/templates/uploadToAzure.yml [6].

Addition of a new PowerShell script:

  • Added tools/installPSResources.ps1 to handle the installation of specific PowerShell modules from either the PSGallery or a custom feed.

PR Context

PR Checklist

@jshigetomi
Copy link
Collaborator Author

/azp run

@jshigetomi jshigetomi marked this pull request as ready for review March 3, 2025 21:28
@jshigetomi jshigetomi requested a review from a team as a code owner March 3, 2025 21:28
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

TravisEz13
TravisEz13 approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify that binary and package builds run.

andyleejordan
andyleejordan previously requested changes Mar 3, 2025
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Half or more of the instances where we're installing Az.Accounts and Az.Storage from the CFS feed using Install-PSResource are happening in places where there's existing logic to check if the PowerShell AzureRM module is installed, and then uninstalling it, and then installing our packages. What's up with that?

@microsoft-github-policy-service microsoft-github-policy-service bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Mar 3, 2025
@andyleejordan
Copy link
Member

How's this different from #25123?

@jshigetomi
Copy link
Collaborator Author

jshigetomi commented Mar 5, 2025 •
edited
Loading

How's this different from #25123?

This one is going into master, the other one is testing these changes on the internal 7.4.9 release to verify it works. The plan is to merge this into master once its verified on the other branch.
Should be the same thing.

@jshigetomi jshigetomi changed the title Add tool to download modules from CFS and change download methods in pipeliine Remove Az module installs and AzureRM uninstalls in pipeline Mar 11, 2025
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 11, 2025
@TravisEz13
Copy link
Member

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13 TravisEz13 enabled auto-merge (squash) March 11, 2025 19:50
@TravisEz13 TravisEz13 disabled auto-merge March 11, 2025 19:50
@TravisEz13 TravisEz13 merged commit 4bc918b into master Mar 11, 2025
35 of 36 checks passed
@TravisEz13 TravisEz13 deleted the switchToCFS branch March 11, 2025 19:53
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Mar 11, 2025 •
edited by unfurl-links bot
Loading

📣 Hey @jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

jshigetomi added a commit that referenced this pull request Mar 12, 2025
@jshigetomi
Remove Az module installs and AzureRM uninstalls in pipeline (#25118)
04d131e 
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
@jshigetomi jshigetomi mentioned this pull request Mar 12, 2025
Merged
pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull request Apr 11, 2025
@jshigetomi @pwshBot
Cherry-pick PR PowerShell#25118 with conflicts for manual resolution
185da3c
@pwshBot pwshBot mentioned this pull request Apr 11, 2025
Merged
9 tasks
jshigetomi added a commit that referenced this pull request Apr 12, 2025
@jshigetomi
Remove Az module installs and AzureRM uninstalls in pipeline (#25118)
b4496af 
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@andyleejordan andyleejordan Awaiting requested review from andyleejordan

Assignees

No one assigned

Labels

BackPort-7.4.x-Done BackPort-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

PowerShell Team Reviews/Investigations
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jshigetomi @andyleejordan @TravisEz13 @adityapatwardhan