Refactor CompletionHelpers HandleDoubleAndSingleQuote to have less nesting logic
#25179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have we tests covering the method? |
@iSazonov So currently no tests other than tests covering the command completion. I can include XUnit tests in another PR then this one can be covered. |
|
Test will be covered in #25181 if we want to merge that in first. |
|
Waiting tests... |
iSazonov
reviewed
Mar 15, 2025
src/System.Management.Automation/engine/CommandCompletion/CompletionHelpers.cs
Outdated
Show resolved
Hide resolved
iSazonov
reviewed
Mar 15, 2025
src/System.Management.Automation/engine/CommandCompletion/CompletionHelpers.cs
Outdated
Show resolved
Hide resolved
iSazonov
reviewed
Mar 15, 2025
src/System.Management.Automation/engine/CommandCompletion/CompletionHelpers.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionHelpers.cs
Outdated
Show resolved
Hide resolved
…letionHelpers.cs Co-authored-by: Ilya <darpa@yandex.ru>
iSazonov
added
CL-General
|
I'll look into test failures for this one. |
iSazonov
reviewed
Mar 17, 2025
| bool hasBackSingleQuote = backQuote.IsSingleQuote(); | ||
| bool hasBackDoubleQuote = backQuote.IsDoubleQuote(); | ||
|
|
||
| bool hasMatchingFrontAndBackQuote = |
There was a problem hiding this comment.
Maybe hasBothFrontAndBackQuotes ?
| return quoteInUse; | ||
| } | ||
|
|
||
| bool hasValidFrontQuoteAndNoMatchingBackQuote = |
There was a problem hiding this comment.
Maybe hasFrontQuoteAndNoBackQuote?
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
iSazonov
approved these changes
Mar 17, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
📣 Hey @ArmaanMcleod, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
iSazonov
added
CL-CodeCleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Refactor
HandleDoubleAndSingleQuotemethod to have less nesting logic so it is easier to understand.The current code is very hard to understand in comparison to the flatter version which has less nesting and more clearer variable names and intention.
Obviously just a preference, I am happy to close this PR if people don't find the new refactoring an improvement.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).