Make inherited protected internal instance members accessible in class scope. #25245

mawosoft · 2025-03-27T02:35:41Z

PR Summary

This PR enables PowerShell classes to access inherited protected internal instance members in addition to protected ones. It expands the existing scope checks for IsFamily to check for both IsFamily and IsFamilyOrAssembly.

Fixes #24898.

PR Context

After switching to .NET 9 in Powershell 7.5, PowerShell classes can no longer call $this.MemberwiseClone() because the API signature of the method in the .NET SDK was changed from protected to protected internal. Other APIs may be affected as well, but this is the most notable problem, causing a breaking change when existing scripts switch from PowerShell 7.4 to 7.5 or newer.

To speed up the review process, this PR makes only minimal changes adressing access to inherited instance members. These changes should be backported to 7.5 immediately (bugfix). A backport to 7.4 should also be considered (enhancement).

Future considerations for inherited static members

At the moment, PowerShell classes can only access public inherited static members. If it is desirable to allow access to protected and protected internal static members as well, I already have a separate PR ready to submit, after this one has been merged.

PR Checklist

test/powershell/Language/Classes/scripting.Classes.inheritance.tests.ps1

iSazonov · 2025-03-27T05:08:08Z

@mawosoft Please look CI failures. I see only 8 failed tests.

iSazonov · 2025-03-27T16:52:31Z

@mawosoft Let's wait MSFT team member's review. It can take a long time.

…ass scope.

…ss scope.

- Remove tests for static members because this PR is limited to instance members. - Add tests for accessing instance members dynamically. - Clean up code and clarify test descriptions.

mawosoft · 2025-04-07T19:17:53Z

@iSazonov, @SeeminglyScience, @daxian-dbw

To speed up the review process, this PR makes only minimal changes adressing access to inherited instance members. These changes should be backported to 7.5 immediately (bugfix). A backport to 7.4 should also be considered (enhancement).

Future considerations for inherited static members

At the moment, PowerShell classes can only access public inherited static members. If it is desirable to allow access to protected and protected internal static members as well, I already have a separate PR ready to submit, after this one has been merged.

See PR description.

iSazonov · 2025-04-08T03:57:17Z

After switching to .NET 9 in Powershell 7.5, PowerShell classes can no longer call $this.MemberwiseClone()

Can we have a test to ensure this now works?

mawosoft · 2025-04-08T05:20:17Z

Can we have a test to ensure this now works?

@iSazonov Done.

FabienTschanz · 2025-04-28T12:17:49Z

Any chance we can get this PR reviewed? Thank you!

daxian-dbw · 2025-05-09T20:37:49Z

Sorry for the long delay! I will make sure review this PR next Monday.

daxian-dbw

@mawosoft Again, sorry for the long delay! The product changes look good to me, but I left 2 comments in the test changes. Please take a look, thanks!

test/powershell/Language/Classes/scripting.Classes.inheritance.tests.ps1

daxian-dbw · 2025-05-12T21:28:18Z

/azp run PowerShell-CI-linux-packaging PowerShell-Windows-Packaging-CI

azure-pipelines · 2025-05-12T21:28:24Z

No pipelines are associated with this pull request.

microsoft-github-policy-service · 2025-05-12T21:30:33Z

📣 Hey @@mawosoft, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Microsoft Forms

mawosoft · 2025-05-12T22:46:30Z

@daxian-dbw What are your thoughts on doing this for static members as well? See "future considerations" in the PR Context at the top.

Also, don't forget to backport to 7.5 :) Not sure how that selection process works here.

daxian-dbw · 2025-05-12T23:34:12Z

I agree to support the same for static members for the sake of consistency. Please submit a new PR for that. Thank you!

…rShell class scope (PowerShell#25245)

…scope. Follow up for PowerShell#25245.

This comment was marked as outdated.

Sign in to view

iSazonov requested a review from SeeminglyScience March 27, 2025 03:15

iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Mar 27, 2025

iSazonov reviewed Mar 27, 2025

View reviewed changes

test/powershell/Language/Classes/scripting.Classes.inheritance.tests.ps1 Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

iSazonov requested a review from daxian-dbw March 27, 2025 16:44

microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Apr 4, 2025

mawosoft added 4 commits April 7, 2025 19:08

Add tests for accessing protected (internal) base class members in cl…

5277eb8

…ass scope.

Make protected internal base class instance members accessible in cla…

542a2d1

…ss scope.

Revert accidental style changes as suggested by code review.

88318e7

Refactor tests.

9a52805

- Remove tests for static members because this PR is limited to instance members. - Add tests for accessing instance members dynamically. - Clean up code and clarify test descriptions.

mawosoft force-pushed the fix-24898 branch from 48364f2 to 9a52805 Compare April 7, 2025 19:09

mawosoft changed the title ~~WIP: Make protected internal base class members accessible in class scope.~~ Make inherited protected internal instance members accessible in class scope. Apr 7, 2025

microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Apr 8, 2025

Add explicit test for $this.MemberwiseClone()

7afd181

microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Apr 15, 2025

microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label May 9, 2025

daxian-dbw added this to PowerShell Team Reviews/Investigations May 9, 2025

daxian-dbw moved this to PR In Progress in PowerShell Team Reviews/Investigations May 9, 2025

daxian-dbw self-assigned this May 9, 2025

daxian-dbw requested changes May 12, 2025

View reviewed changes

test/powershell/Language/Classes/scripting.Classes.inheritance.tests.ps1 Show resolved Hide resolved

test/powershell/Language/Classes/scripting.Classes.inheritance.tests.ps1 Show resolved Hide resolved

microsoft-github-policy-service bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels May 12, 2025

daxian-dbw approved these changes May 12, 2025

View reviewed changes

daxian-dbw merged commit eb1cc6d into PowerShell:master May 12, 2025
38 checks passed

github-project-automation bot moved this from PR In Progress to Done in PowerShell Team Reviews/Investigations May 12, 2025

daxian-dbw added the BackPort-7.5.x-Consider label May 12, 2025

pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull request May 12, 2025

Make inherited protected internal instance members accessible in Powe…

03d41fd

…rShell class scope (PowerShell#25245)

pwshBot mentioned this pull request May 12, 2025

[release/v7.5] Make inherited protected internal instance members accessible in class scope. #25547

Merged

9 tasks

mawosoft added a commit to mawosoft/PowerShell that referenced this pull request May 13, 2025

Make inherited protected internal static members accessible in class …

f221dd4

…scope. Follow up for PowerShell#25245.

mawosoft mentioned this pull request May 13, 2025

Make inherited protected (internal) static members accessible in class scope. #25551

Open

12 tasks

TravisEz13 added Backport-7.4.x-Migrated and removed BackPort-7.5.x-Consider labels May 14, 2025

Make inherited protected internal instance members accessible in class scope. #25245

Make inherited protected internal instance members accessible in class scope. #25245

Uh oh!

Conversation

mawosoft commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

Future considerations for inherited static members

PR Checklist

Uh oh!

This comment was marked as outdated.

Uh oh!

iSazonov commented Mar 27, 2025

Uh oh!

This comment was marked as outdated.

iSazonov commented Mar 27, 2025

Uh oh!

mawosoft commented Apr 7, 2025

Future considerations for inherited static members

Uh oh!

iSazonov commented Apr 8, 2025

Uh oh!

mawosoft commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FabienTschanz commented Apr 28, 2025

Uh oh!

daxian-dbw commented May 9, 2025

Uh oh!

daxian-dbw left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

daxian-dbw commented May 12, 2025

Uh oh!

azure-pipelines bot commented May 12, 2025

Uh oh!

Uh oh!

microsoft-github-policy-service bot commented May 12, 2025 • edited by unfurl-links bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mawosoft commented May 12, 2025

Uh oh!

daxian-dbw commented May 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mawosoft commented Mar 27, 2025 •

edited

Loading

mawosoft commented Apr 8, 2025 •

edited

Loading

daxian-dbw left a comment •

edited

Loading

microsoft-github-policy-service bot commented May 12, 2025 •

edited by unfurl-links bot

Loading