/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Microsoft Forms

@TravisEz13 I missed this one, aren't you concerned about CI suddenly breaking if latest changes? Shouldn't this stay as a pinned version?

I agree with @JustinGrote here. We need to understand the reasoning for this chnage, which should have been added as Context to this pr, which is missing

The environment is continuously changing. We can pin again if we are broken. 20.04 is currently in brown out. This was a required change to keep the CI functioning. We can pin to 22.04 if needed. I would prefer to see the changes to the environment and be aware than discover it when we are forced to move again.

I'll try to include the context, but I was in a rush to get the system working again during the 20.04 brown out.

Reasonable, it's not like the 20.04 brown out was a secret though.

https://github.blog/changelog/2025-01-15-github-actions-ubuntu-20-runner-image-brownout-dates-and-other-breaking-changes/#ubuntu-20-image-is-closing-down
https://github.blog/changelog/2025-02-12-notice-of-upcoming-deprecations-and-breaking-changes-for-github-actions/
actions/runner-images#11101

It's my opinion that it is better to be potentially broken (assuming the notice isn't observed in the future) by a well known deprecation that provides a well known error message when it happens, than to be broken by some unknown change in a "latest" update that may be difficult to troubleshoot, or even know that a rev happened, so I vote for the pin to 24.04 if possible, 22.04 if that is all that is supported for now.

What is the problem? That there may be versions of Ubuntu that we will never support? Or is it that something might break at the most inopportune moment?

Wouldn't it be easiest to just create optional CI with the ubuntu-latest version? This will immediately flag the change.

@iSazonov I'm concerned about the latter, that suddenly ubuntu-latest becomes 26.04 and it breaks the build in a non-specific way (e.g. error that says libso4.so.dll not found) that might be way hard to figure out until you realize the distro bumped. Rollouts like these come with no specific notice either as they come in rings, whereas the team can control for issues by simply PRing a version bump to the github action and seeing how it does on that branch before merging. You know, like every other change made to the repo.

I agree that doing a matrix with both ubuntu-latest and a pinned version would also likely (somewhat) clearly indicate the issue, so that is also acceptable.