KEMBAR78
Use GitHubReleaseTask by jshigetomi · Pull Request #25398 · PowerShell/PowerShell · GitHub
Skip to content

Conversation

@jshigetomi
Copy link
Collaborator

@jshigetomi jshigetomi commented Apr 21, 2025

PR Summary

This pull request updates the release pipeline to replace the previous "Set Tag and Upload Tools" stage with a new "Set Tag and Upload Changelog" stage. The changes streamline the release process by removing tool-related steps and introducing changelog management. Below are the most important changes grouped by theme:

Pipeline Stage Updates:

  • Renamed the pipeline stage from setReleaseTagAndUploadTools to setReleaseTagAndChangelog in .pipelines/PowerShell-Release-Official.yml. Updated the display name and corresponding template reference to release-SetTagAndChangelog.yml. [1] [2]

Template Modifications:

  • Renamed the template file .pipelines/templates/release-SetTagAndTools.yml to .pipelines/templates/release-SetTagAndChangelog.yml. Updated the job name and display name accordingly.
  • Removed all steps related to uploading and signing tools from the release-SetTagAndChangelog.yml template, focusing the job solely on changelog-related tasks.

GitHub Release Enhancements:

  • Updated the release-githubNuget.yml template to replace the usage of SetTagAndTools outputs with SetTagAndChangelog outputs for variables like ReleaseTag and Version. [1] [2]
  • Added steps to generate and verify a release notes file (release-notes.md) and set variables for GitHub release tasks, such as IsPreRelease and ReleaseNotesFilePath.
  • Introduced a new GitHubRelease@1 task for creating GitHub releases, replacing the previous Publish-ReleaseDraft step.

These changes simplify the pipeline by removing tool-related operations and enhancing changelog and release management.

PR Context

PR Checklist

@jshigetomi
Copy link
Collaborator Author

This task will not push a tag, it will only prefill the draft with a tag name. The tag will push on publishing of the draft.
The target branch can be changed in the draft.

@jshigetomi jshigetomi added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log BackPort-7.4.x-Consider BackPort-7.5.x-Consider labels Apr 21, 2025
@jshigetomi jshigetomi marked this pull request as ready for review April 21, 2025 19:06
@jshigetomi jshigetomi requested a review from a team as a code owner April 21, 2025 19:06
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@microsoft-github-policy-service microsoft-github-policy-service bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 21, 2025
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 21, 2025
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
@TravisEz13
Copy link
Member

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13 TravisEz13 enabled auto-merge (squash) April 21, 2025 21:44
@TravisEz13 TravisEz13 merged commit fa4f5b6 into master Apr 21, 2025
35 checks passed
@TravisEz13 TravisEz13 deleted the GitHubReleaseTask branch April 21, 2025 21:44
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Apr 21, 2025

📣 Hey @@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull request Apr 21, 2025
pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull request Apr 21, 2025
Sysoiev-Yurii pushed a commit to Sysoiev-Yurii/PowerShell that referenced this pull request May 12, 2025
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BackPort-7.4.x-Done Backport-7.5.x-Migrated CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants