Adding PS* aliases for Where|Foreach magic methods #25511
Merged
+30
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
reviewed
May 5, 2025
src/System.Management.Automation/engine/runtime/Binding/Binders.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/runtime/Binding/Binders.cs
Outdated
Show resolved
Hide resolved
powercode
force-pushed
the
ps_where_foreach
branch
2 times, most recently
from
3efafd6 to
1641ec2
Compare
powercode
added
the
CL-Engine
powercode
force-pushed
the
ps_where_foreach
branch
from
1641ec2 to
06e052f
Compare
$list = [System.Collections.Generic.List[int]]::new([int[]]@(1..10))
$list.PSForEach{$_} |
|
@daxian-dbw Sorry for the messy PR - should be good for review now. |
daxian-dbw
reviewed
May 5, 2025
src/System.Management.Automation/engine/runtime/Binding/Binders.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/runtime/Binding/Binders.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/runtime/Binding/Binders.cs
Outdated
Show resolved
Hide resolved
…s.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
powercode
force-pushed
the
ps_where_foreach
branch
from
1b79373 to
98f4ebd
Compare
daxian-dbw
approved these changes
May 5, 2025
daxian-dbw
moved this from Done
to PR In Progress
in PowerShell Team Reviews/Investigations
|
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
github-project-automation
bot
moved this from PR In Progress
to Done
in PowerShell Team Reviews/Investigations
|
📣 Hey @@powercode, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
#25432
PR Context
Adds PSWhere and PSForEach methods to the binder as aliases for the Where and Foreach magic methods.
This works around the issue on
List<T>where a ForEach method is defined that hides the magic method.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header