KEMBAR78
Move MSIXBundle to Packages and Release to GitHub by jshigetomi · Pull Request #25512 · PowerShell/PowerShell · GitHub
Skip to content

Conversation

@jshigetomi
Copy link
Collaborator

@jshigetomi jshigetomi commented May 6, 2025

  • Move MSIXBundle stage to package pipeline
  • Add dependency
  • Add dependency for for upload stage
  • Move upload of MSIXBundle to upload stage
  • Remove single quotes
  • fix filter
  • Resolve bundle name correctly
  • correct spacing
  • Add container variable step
  • Fix pipeline name

PR Summary

This pull request introduces changes to the Azure DevOps pipeline configurations to streamline the handling of MSIX bundles. The updates include adding a new MSIX bundle creation stage, integrating its artifacts into the upload process, and refactoring the MSIX-related logic for better reusability and clarity.

Pipeline Updates for MSIX Bundles:

  • Addition of MSIX Bundle Creation Stage: A new msixbundle stage was added to the PowerShell-Packages-Official.yml pipeline, which depends on the windows_package stage and uses the newly created package-create-msix.yml template. This ensures MSIX bundles are generated as part of the build process. ([.pipelines/PowerShell-Packages-Official.ymlR250-R257](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-94820840eb18ab110a6244f06a5d156e757c980ceebcfe03a4f2591bb67bc859R250-R257))
  • Integration of MSIX Artifacts into Upload Stage: The upload stage in the PowerShell-Packages-Official.yml pipeline now depends on the msixbundle stage, ensuring that MSIX artifacts are included in the final upload process. ([.pipelines/PowerShell-Packages-Official.ymlR250-R257](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-94820840eb18ab110a6244f06a5d156e757c980ceebcfe03a4f2591bb67bc859R250-R257))

Refactoring and Template Improvements:

  • Renaming and Refactoring MSIX Template: The release-create-msix.yml template was renamed to package-create-msix.yml and updated to use DownloadPipelineArtifact@2 tasks for downloading artifacts. This improves clarity and aligns with standard practices. ([[1]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-b09ac31caeda1400a115a970686df9fc86ed1f1c648277e2ed3d7e6973f7bb4bL16-R41), [[2]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-b09ac31caeda1400a115a970686df9fc86ed1f1c648277e2ed3d7e6973f7bb4bL56-R68))
  • Simplified Artifact Handling: The MSIX template now uses a consistent artifact staging directory (Build.ArtifactStagingDirectory) for downloads and processing, replacing hardcoded paths. ([[1]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-b09ac31caeda1400a115a970686df9fc86ed1f1c648277e2ed3d7e6973f7bb4bL56-R68), [[2]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-b09ac31caeda1400a115a970686df9fc86ed1f1c648277e2ed3d7e6973f7bb4bL90-L129))

Removal of MSIX Logic from Release Pipeline:

  • Removal of MSIX Stage in Release Pipeline: The msixbundle stage was removed from the PowerShell-Release-Official.yml pipeline, as its functionality has been consolidated into the PowerShell-Packages-Official.yml pipeline. ([[1]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-b25fb4a8cfad5e36ba1c9c9c7cbe494fce4eed0067878610ebb12ffcab7e41cdL125-L130), [[2]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-b25fb4a8cfad5e36ba1c9c9c7cbe494fce4eed0067878610ebb12ffcab7e41cdL273))

Enhancements to Upload Logic:

  • MSIXBundle Upload in uploadToAzure.yml: Added logic to upload MSIX bundles to Azure Blob Storage, including handling for existing blobs to avoid duplication. ([[1]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-198718b336446a8a528c995da4f1bc5edf20c0ba40ea06852fece3512c67e0c9R237-R245), [[2]](https://github.com/PowerShell/PowerShell/pull/25512/files#diff-198718b336446a8a528c995da4f1bc5edf20c0ba40ea06852fece3512c67e0c9R412-R434))

PR Context

PR Checklist

@jshigetomi jshigetomi added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log BackPort-7.4.x-Consider BackPort-7.5.x-Consider labels May 6, 2025
@jshigetomi jshigetomi marked this pull request as ready for review May 6, 2025 00:31
@jshigetomi jshigetomi requested a review from a team as a code owner May 6, 2025 00:31
@TravisEz13
Copy link
Member

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13 TravisEz13 merged commit 2274a88 into master May 6, 2025
45 of 46 checks passed
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented May 6, 2025

📣 Hey @@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.4.x-Migrated Backport-7.5.x-Migrated CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants