KEMBAR78
Remove AsyncSDL from Pipelines Toggle Official/NonOfficial Runs by jshigetomi · Pull Request #25885 · PowerShell/PowerShell · GitHub
Skip to content

Conversation

@jshigetomi
Copy link
Collaborator

@jshigetomi jshigetomi commented Aug 21, 2025

  • Remove asyncSDL and add officialness parameter to all pipelines
  • Use boolean for toggling official and toggle release environment
  • Turn on binskim globalization invariant
  • Try as a variable
  • Set binskim exact tool version to 4.4.2

PR Summary

This pull request updates several Azure Pipeline YAML files to improve build configuration flexibility and security scanning consistency. The main changes introduce a new OfficialBuild parameter to control template selection and environment variables, standardize the use of BinSkim with a fixed tool version, and clean up legacy or redundant SDL scanning steps.

Build configuration improvements:

  • Added an OfficialBuild boolean parameter to multiple pipeline YAML files to allow conditional selection of official vs. non-official build templates. This enables more flexible build configurations based on the build type. [1] [2] [3] [4]
  • Updated template references to use the new templateFile variable, which is set based on the OfficialBuild parameter, ensuring the correct pipeline template is used for each build. [1] [2] [3] [4] [5] [6] [7]

Security scanning adjustments:

  • Set exactToolVersion: 4.4.2 for BinSkim across all pipelines to standardize the tool version and avoid compatibility issues. [1] [2] [3] [4] [5] [6]
  • Disabled BinSkim at the job level and set related environment variables to fix known issues with ICU packages in Linux containers. [1] [2]
  • Enabled incrementalSDLBinaryAnalysis in feature flags for more efficient and targeted security analysis. [1] [2] [3] [4]

Legacy and redundant step clean-up:

  • Removed legacy or redundant asyncSDL and credscan steps from several pipeline configurations to simplify and modernize the security scanning process. [1] [2] [3] [4]

Environment variable management:

  • Added logic to set the releaseEnvironment variable based on the OfficialBuild parameter, ensuring the correct environment context for release pipelines. [1] [2]

These changes collectively improve pipeline maintainability, security scanning reliability, and build environment flexibility.

PR Context

PR Checklist

@jshigetomi jshigetomi requested a review from a team as a code owner August 21, 2025 21:46
@jshigetomi jshigetomi added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log BackPort-7.4.x-Consider BackPort-7.5.x-Consider labels Aug 21, 2025
@TravisEz13
Copy link
Member

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TravisEz13 TravisEz13 self-assigned this Aug 25, 2025
@TravisEz13 TravisEz13 merged commit 10a8226 into master Aug 25, 2025
44 of 45 checks passed
@TravisEz13 TravisEz13 deleted the removeAsyncSDL branch August 25, 2025 17:30
@microsoft-github-policy-service
Copy link
Contributor

📣 Hey @@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BackPort-7.4.x-Done BackPort-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants