KEMBAR78
Change the default feedback provider timeout from 300ms to 1000ms by daxian-dbw · Pull Request #25910 · PowerShell/PowerShell · GitHub
Skip to content

Change the default feedback provider timeout from 300ms to 1000ms #25910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2025
Merged

Change the default feedback provider timeout from 300ms to 1000ms #25910

merged 1 commit into from
Aug 26, 2025

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Aug 25, 2025 •
edited
Loading

PR Summary

Fix #25863

The WinGet feedback provider has perf regression and now cannot return results within 300ms. See #25863 (comment) for details.
This PR changes the default feedback provider timeout from 300ms to 1000ms to allow the WinGet feedback provider to work.

Note that this doesn't mean a user will always wait for 1 second.

  • If all feedback providers return earlier than that, then the user will wait for the one that takes the longest;
  • If any feedback provider cannot return before the 1000ms timeout, then the user will wait for the whole 1 second.

This is a short-term fix. In the long term, we need to improve the UI of feedback provider to allow a much larger default timeout (tracked by #25909).

PR Checklist

@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Aug 25, 2025
@daxian-dbw daxian-dbw marked this pull request as ready for review August 25, 2025 18:00
@kilasuit
Copy link
Collaborator

@daxian-dbw - Approving as this is a simple enough change.

@iSazonov
Copy link
Collaborator

/azp run PowerShell-CI-linux-packaging,PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

StevenBucher98
StevenBucher98 approved these changes Aug 26, 2025
View reviewed changes
Copy link
Collaborator

@StevenBucher98 StevenBucher98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with increasing the timeout

@daxian-dbw daxian-dbw merged commit 44e34f0 into PowerShell:master Aug 26, 2025
38 of 39 checks passed
@daxian-dbw daxian-dbw deleted the timeout branch August 26, 2025 23:06
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Aug 26, 2025 •
edited by unfurl-links bot
Loading

📣 Hey @@daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience

@jshigetomi jshigetomi Awaiting requested review from jshigetomi

+2 more reviewers

@kilasuit kilasuit kilasuit approved these changes

@StevenBucher98 StevenBucher98 StevenBucher98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PowerShell 7.5 “Command Not Found” Feature Is Broken Without Stable Dependencies

4 participants

@daxian-dbw @kilasuit @iSazonov @StevenBucher98