Add build to vPack Pipeline #25915
Merged
Add build to vPack Pipeline #25915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshigetomi
commented
Aug 26, 2025
jshigetomi
commented
Aug 26, 2025
jshigetomi
added
CL-BuildPackaging
Remove reference to packages pipeline Use repoRoot set architecture variable to string set and use variable architecutre Get the fullname of all artifacrts Look in Symbols_Arch for all files Initialize PowerShellRoot for signing template Skip signature validation for now revert signature validation Look for tsa and credscan in pipeline.workspace revert signature validation Look for tsa and credscan in pipeline.workspace turn off sig val check for test cert sigining in pipeline and Update-PSSignedBuildFolder Pass parameter to signing template Use bool not string cast to boolean Add parameter to second call to method look for credscan in pipeline.workspace revert windows-hosted build change Revert credscan define artifactPlatform Remove checkout define artifactPlatform Remove checkout maintain checkout to only s Add parameter for vPack name Remove template Add parameter names
jshigetomi
force-pushed
the
addBuildTovPack
branch
from
e19735c to
aa7539b
Compare
|
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Remove reference to packages pipeline Use repoRoot set architecture variable to string set and use variable architecutre Get the fullname of all artifacrts Look in Symbols_Arch for all files Initialize PowerShellRoot for signing template Skip signature validation for now revert signature validation Look for tsa and credscan in pipeline.workspace revert signature validation Look for tsa and credscan in pipeline.workspace turn off sig val check for test cert sigining in pipeline and Update-PSSignedBuildFolder Pass parameter to signing template Use bool not string cast to boolean Add parameter to second call to method look for credscan in pipeline.workspace revert windows-hosted build change Revert credscan define artifactPlatform Remove checkout define artifactPlatform Remove checkout maintain checkout to only s Add parameter for vPack name Remove template Add parameter names
…lBuild and debug, and adjust vPackName settings
This comment was marked as spam.
This comment was marked as spam.
|
Instalar |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
adityapatwardhan
approved these changes
Sep 2, 2025
TravisEz13
reviewed
Sep 2, 2025
|
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
|
Azure Pipelines successfully started running 2 pipeline(s). |
TravisEz13
approved these changes
Sep 3, 2025
TravisEz13
added
BackPort-7.4.x-Approved
BackPort-7.5.x-Approved
and removed
BackPort-7.4.x-Consider
BackPort-7.5.x-Consider
labels
|
📣 Hey @@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
pwshBot
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
Sep 3, 2025
9 tasks
pwshBot
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
Sep 4, 2025
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request introduces significant improvements to the PowerShell build pipeline by making the build and signing process more flexible and robust. The main changes allow the pipeline to distinguish between official and non-official builds, dynamically select templates, and provide more granular handling of code signing. These updates make it easier to manage different build scenarios and improve the reliability and clarity of signing checks.
Pipeline configuration and template selection:
OfficialBuildboolean parameter andvPackNameparameter to.pipelines/PowerShell-vPack-Official.yml, enabling selection between official and non-official build templates and scenarios.templateFilevariable, allowing the pipeline to choose betweenMicrosoft.Official.ymlandMicrosoft.NonOfficial.ymlbased on the build type. [1] [2]Build and artifact handling:
PowerShellRootandRuntimevariables, and improved output and artifact directory management for clarity and consistency. [1] [2] [3]Code signing improvements:
.pipelines/templates/obp-file-signing.ymlandtools/packaging/packaging.psm1to accept and propagate theOfficialBuildparameter, allowing signing logic to distinguish between official and non-official builds and adjust signature checks and warnings accordingly. [1] [2] [3] [4] [5] [6]SigningProfileparameter, supporting different signing requirements for official and non-official builds.These changes collectively improve the maintainability and reliability of the pipeline, especially around build type selection and code signing.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header