-
Notifications
You must be signed in to change notification settings - Fork 8k
Remove UseDotnet task and use the dotnet-install script #26093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
reviewed
Sep 30, 2025
TravisEz13
reviewed
Sep 30, 2025
TravisEz13
reviewed
Sep 30, 2025
aed9e4e to
ff1ce57
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
TravisEz13
approved these changes
Oct 1, 2025
Contributor
|
📣 Hey @@adityapatwardhan, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
pwshBot
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
Oct 9, 2025
9 tasks
pwshBot
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
Oct 9, 2025
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport-7.4.x-Migrated
Backport-7.5.x-Migrated
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request refactors how the .NET SDK is installed in the build pipelines by introducing a new reusable template and updating all relevant pipeline templates to use it. It also updates the
Install-Dotnetfunction to use a new download URL and cleans up legacy code paths. Additionally, it introduces a new pipeline parameter to control network isolation. These changes improve maintainability, consistency, and flexibility across the build system.Pipeline .NET SDK Installation Refactor:
Added a new reusable template
install-dotnet.ymlfor installing the .NET SDK, replacing multiple direct usages of theUseDotNet@2task across all major pipeline templates (linux.yml,mac.yml,nupkg.yml,release-validate-fxdpackages.yml,release-validate-globaltools.yml,release-validate-sdk.yml,testartifacts.yml,windows-hosted-build.yml,windows-package-build.yml,linux-package-build.yml). This centralizes and standardizes .NET installation logic. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Updated scripts in
windows-hosted-build.ymlandwindows-package-build.ymlto explicitly callFind-Dotnetafter .NET installation, ensuring the correct .NET executable is located before proceeding. [1] [2] [3]Improvements to Install-Dotnet Script:
Install-Dotnetfunction inbuild.psm1to use the new download URLhttps://builds.dotnet.microsoft.com/dotnet/scripts/v1, and removed legacy code that handled different PowerShell environments, simplifying the function. [1] [2] [3]Pipeline Flexibility and Parameters:
disableNetworkIsolationto.pipelines/PowerShell-Packages-Official.yml, allowing builds to optionally disable network isolation via pipeline configuration, and propagated this parameter through variables and template invocations. [1] [2] [3]Other Pipeline Improvements:
PR Context
Allows the ability to use pre-release .NET SDKs
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header