Upgrade .Net Core 3 SDK from preview5 to preview6 and related out of band Nuget packages from 2.1 to 3.0-preview6 #9888

bergmeister · 2019-06-13T16:59:04Z

PR Summary

Upgrade .Net Core 3 SDK from preview5 to preview6 and keep Nuget package Microsoft.AspNetCore.Mvc.NewtonsoftJson used for testing in sync with it

This required fixing the namespace ambiguity between System.Management.Automation.AllowNullAttribute and System.Diagnostics.CodeAnalysis.AllowNullAttribute

Please review the added files to the installer, do we want to ship all WPF localisations? Maybe yes for now but later it might be a good option to just include en-us and offer a cmdlet to download the other ones?

Fixes #9780 because it updates the System.Management NuGet package version from .Net 2.1 to 3.0-preview6

Updating also the 2 NuGet packages System.ServiceProcess.ServiceController and its dependency of Microsoft.Windows.Compatibility would've broken 2 tests and the reason for their failure seems to be unclear (i.e. whether it is a problem of PowerShell itself that is now being exposed or a regression in the System.ServiceProcess.ServiceController NuGet package), therefore their update is deferred.

PR Context

https://devblogs.microsoft.com/dotnet/announcing-net-core-3-0-preview-6

PR Checklist

…age Microsoft.AspNetCore.Mvc.NewtonsoftJson used for testing in sync with it

…llAttribute' and 'System.Diagnostics.CodeAnalysis.AllowNullAttribute and cleanup some unused usings.

bergmeister · 2019-06-13T18:47:23Z

~~@SteveL-MSFT It seems preview6 of .Net Core 3 has bad regressions on non-Windows systems~~
UPDATE, it was accidental change of mine that caused that, sorry

SteveL-MSFT · 2019-06-13T22:15:16Z

@bergmeister can you look in the inner exceptions to see what method it's referring to that is not supported?

bergmeister · 2019-06-13T22:23:27Z

Yes, but only tomorrow.

iSazonov · 2019-06-14T05:24:53Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/AddMember.cs

 using System.Management.Automation.Host;
 using System.Management.Automation.Internal;
 using System.Reflection;
+using AllowNullAttribute = System.Management.Automation.AllowNullAttribute;


I think we can use new System.Diagnostics.CodeAnalysis.AllowNullAttribute

Would there be an advantage, I guess we cannot remove the existing attribute due to it being public. Could this break edge cases where e.g. people analyze attributes on the AST? I am happy to do whatever is desired but this should be thought through before making the change. Opinions @SteveL-MSFT

Let's not make this change in this PR

I recommend to remove the unnecessary [SuppressMessage("xxxx", "xxxxxx")] from those affected files so that we can remove the using System.Diagnostics.CodeAnalysis; directive. Then AllowNullAttribute won't be ambiguous.

@bergmeister Can you please address my comment? Thanks!
Otherwise, the PR looks most ready to go.

src/System.Management.Automation/engine/hostifaces/pipelinebase.cs

iSazonov · 2019-06-14T05:29:06Z

test/tools/WebListener/WebListener.csproj


  <ItemGroup>
-    <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="3.0.0-preview5-19227-01" />
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="3.0.0-preview6.19307.2" />


I think we should update all packages to latest versions. (As soon as we can compile the PR and pass tests.)

Which other packages? This is the only package that I was aware of that is tightly coupled to the runtime

All. Packages we use come from .Net Core 2.*. We need to update to latest preview 3.0.
See #9780

OK, thanks for the reference, I updated all those NuGet packages in a 2nd branch and ran the CI tests and there were only 2 failures on Windows only, if you want I could add this update to this PR (especially since the packages are preview6 specific)?
https://christophbergmeister.visualstudio.com/PowerShell/_build/results?buildId=896&view=ms.vss-test-web.build-test-results-tab

I propose to update step by step (package by package) in the PR. I hope we get this in Preview2 before Core RC.

@iSazonov I found the culprit that contains the breaking change that causes the 2 test failures:
System.ServiceProcess.ServiceController. Therefore we can probably update all NuGet packages except this one and Microsoft.Windows.Compatibility (because it depends on System.ServiceProcess.ServiceController). I am running builds at the moment in my fork to prove this theory. Should I also update the packages in tools\packages\.... (that I think are used to create the NuGet packages for SMA, etc.)? Should the update of possible NuGet packages be in this PR or in a follow up PR (that I'd base it on this PR?)?

bergmeister · 2019-06-14T10:24:11Z

@SteveL-MSFT The failures were due to one line that I accidentally changed/commited.
Apart from Download Artifacts having a general issue in Azure DevOps at the moment, the Windows tests passed. On Linux, Mac there is only 1 failure in the Pester No Sudo - CI test suite:

Validate start of console host.No new assemblies are loaded

Expected exactly $null, but got @(@{InputObject=System.Security.Cryptography.Primitives.dll; SideIndicator=<=}, @{InputObject=System.Security.Principal.dll; SideIndicator=<=}).

at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Host/Startup.Tests.ps1: line 123
123:         $diffs | Should -BeExactly $null

The log says that System.Security.Cryptography.Primitives.dll and System.Security.Principal.dll are not loaded (but expected to be)

SteveL-MSFT · 2019-06-14T16:51:03Z

@bergmeister I believe you can update the startup tests to not expect those to be loaded. Perhaps .NET did some refactoring that doesn't require those to be loaded during our startup usage.

…aphy.Primitives.dll and System.Security.Principal.dll to be only loaded on Windows

bergmeister · 2019-06-15T11:49:49Z

All tests pass now.
Please review the added files to the installer, do we want to ship all WPF localisations? Maybe yes for now but later it might be a good option to just include en-us and offer a cmdlet to download the other ones?

iSazonov · 2019-06-15T16:22:30Z

If MSFT team plans to include PowerShell 7.0 in Windows distribution the localization story becomes important. I think for preview we can put all in one package.

@bergmeister Thanks for the PR continue. Have you plans to update package versions to latest?

bergmeister · 2019-06-15T17:14:13Z

Yes, but as my comment here there are 2 test failures on Windows only if I updated the NuGet packages
UPDATE:
I found the NuGet packages that contains the breaking change that causes the 2 test failures:
System.ServiceProcess.ServiceController. Therefore we could update all NuGet packages except this one and Microsoft.Windows.Compatibility (because it depends on System.ServiceProcess.ServiceController). Should I also update the packages in tools\packages\.... (that I think are used to create the NuGet packages for SMA, etc.)? Should the update of possible NuGet packages be in this PR or in a follow up PR (that I'd base it on this PR?)? The build of this PR is green at the moment so if review passed, we could merge this already in. cc @SteveL-MSFT

iSazonov · 2019-06-17T03:25:44Z

@bergmeister You can continue in the PR if you want. Maintainers can add new commits as we did in past.

2 test failures: System.ServiceProcess.ServiceController

Pull it in last commit and we will investigate.

Should I also update the packages in tools\packages\

We could try. /cc @TravisEz13

…o netcore3.0-preview6

…ntroller and Microsoft.Windows.Compatibility (which depends on it)

…o netcore3.0-preview6 regenerate installer files after change in master, csproj conflict was just trivial newlines # Conflicts: # assets/files.wxs # src/Microsoft.PowerShell.Commands.Utility/Microsoft.PowerShell.Commands.Utility.csproj

SteveL-MSFT · 2019-07-01T21:46:41Z

@bergmeister if updating to newer versions of those assemblies is the cause of the failure, can we go back to an older one that works with Preview6?

bergmeister · 2019-07-01T21:49:23Z

@SteveL-MSFT Yes, we could just revert b518c73 for a green build if you want to merge some working bits early, which means that only the 2 NuGet packages System.ServiceProcess.ServiceController and its dependency of Microsoft.Windows.Compatibility would be excluded from the update for now and create a tracking issue for them.

assets/files.wxs

iSazonov · 2019-07-02T03:02:43Z

@SteveL-MSFT See my comment above #9888 (comment)

…o netcore3.0-preview6

…Windows.Compatibility (which has a dependency on it). This will make 2 tests fail on Windows:" This reverts commit b518c73.

bergmeister · 2019-07-02T20:59:04Z

@SteveL-MSFT I reverted b518c73 for a green build so that we can merge this in earlier and suggest to add a tracking issue for updating the 2 NuGet packages System.ServiceProcess.ServiceController and its dependency of Microsoft.Windows.Compatibilitylater as they break 2 tests and the reason for their failure seems to be unclear (i.e. whether it is a problem of PowerShell itself that is now being exposed or a regression in the System.ServiceProcess.ServiceController NuGet package)

daxian-dbw · 2019-07-02T21:32:40Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/AddMember.cs

 using System.Management.Automation.Host;
 using System.Management.Automation.Internal;
 using System.Reflection;
+using AllowNullAttribute = System.Management.Automation.AllowNullAttribute;


I recommend to remove the unnecessary [SuppressMessage("xxxx", "xxxxxx")] from those affected files so that we can remove the using System.Diagnostics.CodeAnalysis; directive. Then AllowNullAttribute won't be ambiguous.

iSazonov · 2019-07-03T03:25:01Z

Should we report the problem with System.ServiceProcess.ServiceController to Core team?

daxian-dbw · 2019-07-05T18:30:02Z

Should we report the problem with System.ServiceProcess.ServiceController to Core team?

Yes we should report to the .NET team. Can we get a simple repro of the issue?

… unique in terms of namespace to avoid having to add special static using statements as per code review. Also remove one redundant using statement

bergmeister · 2019-07-05T19:27:42Z

@daxian-dbw I applied the suggestion about the using statements from your comment here.
I m note sure if a repro is easy in terms of the usage of the APIs of the NuGet package, I cannot say if this is a bug in the NuGet package itself or something in PowerShell itself that only know starts to surface somehow. I'd appreciate it if you investigate this or we can open a tracking issue in order to get this merged before 7.0-preview2

daxian-dbw

LGTM.
@SteveL-MSFT Are you OK with removing those outdated SuppressMessage attributes?

daxian-dbw · 2019-07-05T21:11:37Z

@bergmeister Yes, please open a tracking issue with the information you have got. Thanks!

SteveL-MSFT · 2019-07-05T21:35:01Z

@daxian-dbw yes, ok with removing the outdated attributes

bergmeister · 2019-07-05T22:42:43Z

@daxian-dbw I opened issue #10067 to track the problem with the Nuget package. I will now resolve the merge conflict again. After this PR is merged, I plan to open a PR to demonstrate the failure so that the change is much smaller and we can focus on it and try experiments.

…o netcore3.0-preview6 Re-hydrate files.wxs # Conflicts: # assets/files.wxs

ghost · 2019-07-17T20:54:51Z

🎉v7.0.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

* Build(deps): Bump Microsoft.PowerShell.Archive from 1.2.2.0 to 1.2.3.0 in /src/Modules (PowerShell#9593) * Support line continuance with pipe at the start of a line (PowerShell#8938) Expands line continuance for pipelines to allow lines to continue automatically without backticks with the pipe symbol at the start of a line. This adds to the existing functionality where pipes can be used to continue lines by placing them at the end of a line. * Fix use of unicode ellipsis in xml (PowerShell#9589) * Updating committee membership (PowerShell#9577) * Build(deps): Bump System.Data.SqlClient from 4.6.0 to 4.6.1 (PowerShell#9601) * Build(deps): Bump PowerShellGet from 2.1.2 to 2.1.3 in /src/Modules (PowerShell#9600) * Build(deps): Bump Microsoft.Windows.Compatibility from 2.0.1 to 2.1.1 (PowerShell#9605) * Build(deps): Bump NJsonSchema from 9.13.37 to 9.14.1 (PowerShell#9616) Bumps [NJsonSchema](https://github.com/rsuter/NJsonSchema) from 9.13.37 to 9.14.1. - [Release notes](https://github.com/rsuter/NJsonSchema/releases) - [Commits](https://github.com/rsuter/NJsonSchema/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * Convert windows CI to stages (PowerShell#9607) * Switch from BMP to PNG for graphical MSI installer assets (PowerShell#9606) This breaks rendering of images for Windows 7 and Server 2008R2, but it's required for accessibility purposes so that the High Contrast Black theme renders text correctly for accessibility. (Unfortunately, BMP does not support transparency.) * Add checkbox to PR checklist for experimental feature use (PowerShell#9619) * Make sure we always return an object in command searcher (PowerShell#9623) * Remove Workflow from PSSessionType (PowerShell#9618) Remove PSSessionType and IsWorkflowConfigurationType() * Port PowerShell to .NET Core 3.0 (PowerShell#9597) * Attributes.cs - Style / Formatting Fixes (PowerShell#9625) * Update README and metadata.json (PowerShell#9624) * Update version tests to use NextReleaseVersion from metadata.json (PowerShell#9646) * Build(deps): Bump PackageManagement from 1.3.2 to 1.4 in /src/Modules (PowerShell#9650) * Build(deps): Bump PackageManagement from 1.3.2 to 1.4 in /src/Modules Bumps PackageManagement from 1.3.2 to 1.4. Signed-off-by: dependabot[bot] <support@dependabot.com> * Update vNext release branches in dependabot config (PowerShell#9658) * Build(deps): Bump Microsoft.CodeAnalysis.CSharp from 3.0.0 to 3.1.0 (PowerShell#9653) * Disable the debugger when in system lock-down mode (PowerShell#9645) Disable the debugger when in system lock-down mode Fixing master for CVE-2019-0733 * Build(deps): Bump PowerShellGet from 2.1.3 to 2.1.4 in /src/Modules (PowerShell#9691) * Run Start-PSBootStrap in Code Coverage build to install .NET SDK (PowerShell#9690) * Merged PR 8504: Fix syncing modules from powershell gallery by normalizing version numbers Fix syncing modules from powershell gallery by normalizing version numbers and added additional logging. * Fix daily `CodeCoverageAndTest` build by explicitly calling `Start-PSBootStrap` (PowerShell#9724) * Merged PR 8510: Update the target framework for reference assemblies to netcoreapp3.0 Update the target framework for reference assemblies to netcoreapp3.0 * Merged PR 8512: Update version for SDK tests and Microsoft.PowerShell.Native package Update version for SDK tests and Microsoft.PowerShell.Native package * Pin version of netDumbster to 2.0.0.4 (PowerShell#9748) * Update the target framework for reference assemblies to netcoreapp3.0 (PowerShell#9747) Update the target framework for reference assemblies to netcoreapp3.0 * Merged PR 8529: Add cleanup before building test package Add cleanup before building test package * Change log for release 6.2.1 (PowerShell#9760) Changelog for 6.2.1 and fix spellings * Change log 6.1.4 (PowerShell#9759) * Update change log for 6.1.4 Update change log for 6.1.4 * Resolve conflicts * Merged PR 8547: Fix the PowerShell version number in MSI packages Fix the PowerShell version number in MSI packages * Merged PR 8542: changelog draft changelog draft * Update README and metadata.json for 7.0.0-preview.1 release (PowerShell#9767) * Increase timeout of NuGet job to workaround build timeout (PowerShell#9772) * Code Cleanup: Tidy up scriptblock.cs (PowerShell#9732) * Fix `Get-ChildItem -Path` with wildcard char (PowerShell#9257) Unescape non-literal, non-glob path before existence checking. * Build(deps): Bump Microsoft.ApplicationInsights from 2.9.1 to 2.10.0 (PowerShell#9757) * Disable stale bot in favor of an internal bot that we can customize more (PowerShell#9785) * Build(deps): Bump System.Net.Http.WinHttpHandler from 4.5.3 to 4.5.4 (PowerShell#9786) * Use new string.ConCat() in Process.cs (PowerShell#9720) * Build(deps): Bump NJsonSchema from 9.14.1 to 10.0.13 (PowerShell#9805) * Support negative numbers in `-split` operator (PowerShell#8960) * Fix use of `Start-Process http://bing.com` (PowerShell#9793) * Improve whitespace for Parser tests (PowerShell#9806) * Build(deps): Bump NJsonSchema from 10.0.13 to 10.0.14 (PowerShell#9843) * Fix minor style issues come from last commits (PowerShell#9640) * Support DSC compilation on Linux. (PowerShell#9834) * Build(deps): Bump NJsonSchema from 10.0.14 to 10.0.15 (PowerShell#9854) * Have console host not enter command prompt mode when using `Read-Host -Prompt` (PowerShell#9743) `Read-Host` calls into `$Host.UI.Prompt()`. However, this method is also used when the host prompts for mandatory parameters that aren't provided. The method expects to be called when given a `FieldDescription` and if the input starts with `!` it enters `CommandPromptMode`. In this mode, you can type `!?` to request help, for example. However this mode is not something you can use via `Read-Host` (only if calling `$Host.UI.Prompt()` directly passing in a well constructed `FieldDescription`). When using `Read-Host -Prompt`, the cmdlet creates a `FieldDescription` where the name is the prompt and the rest of the properties are empty. The fix is that if `Label` is empty, we can assume it's being called from `Read-Host` rather than being called to prompt for a mandatory parameter and thus not enter `CommandPromptMode`. * Add ability to pass `InitialSessionState` to the `ConsoleShell.Start` (PowerShell#9802) * Build(deps): Bump NJsonSchema from 10.0.15 to 10.0.17 (PowerShell#9862) * Add launchSettings.json for better out of box experience when using Visual Studio (PowerShell#9818) * Build(deps): Bump NJsonSchema from 10.0.17 to 10.0.18 (PowerShell#9875) * Add module to support Pester tests for automating debugger commands (stepInto, stepOut, etc.), along with basic tests (PowerShell#9825) * Build(deps): Bump NJsonSchema from 10.0.18 to 10.0.19 (PowerShell#9885) * Make `UseAbbreviationExpansion` and `TempDrive` official features (PowerShell#9872) * Attempt to work around the zip download issue in Azure DevOps Windows CI (PowerShell#9911) * Fix unix project mappings (PowerShell#9892) * Update to use TSAv2 (PowerShell#9914) * Use yarn to install global tools (PowerShell#9904) * Build(deps): Bump PackageManagement from 1.4 to 1.4.1 in /src/Modules (PowerShell#9820) Bumps PackageManagement from 1.4 to 1.4.1. * Build(deps): Bump PackageManagement from 1.4.1 to 1.4.2 in /src/Modules (PowerShell#9918) * Import-DscResource should allow to overwrite DSC built-in resources. (PowerShell#9879) * Use the original precision (prior-dotnet-core-3) for double/fload-to-string conversion (PowerShell#9893) .NET Core changes to return "shortest roundtrippable string" by default for the ToString() method of double and float types. This results in ToString() for double/float values sometimes return a string in 17-digit/9-digit precision format. This PR updated the double/float-to-string conversion in PowerShell to continue using the old precision specifier before the change in .NET Core 3.0. * Build(deps): Bump PowerShellGet from 2.1.4 to 2.1.5 in /src/Modules (PowerShell#9933) Bumps [PowerShellGet](https://github.com/PowerShell/PowerShellGet) from 2.1.4 to 2.1.5. - [Release notes](https://github.com/PowerShell/PowerShellGet/releases) - [Changelog](https://github.com/PowerShell/PowerShellGet/blob/development/CHANGELOG.md) - [Commits](https://github.com/PowerShell/PowerShellGet/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Clean up the use of 'SetProfileRoot' and 'StartProfile' in ConsoleHost (PowerShell#9931) * Clean up the use of 'SetProfileRoot' and 'StartProfile' in ConsoleHost * Remove 'pwsh.pdb' from our component file list * Update console startup and help url for PowerShell docs (PowerShell#9775) * Fix minor CodeFactor style issues in ModuleCmdletBase (PowerShell#9915) * Build(deps): Bump NJsonSchema from 10.0.19 to 10.0.20 (PowerShell#9954) Bumps [NJsonSchema](https://github.com/rsuter/NJsonSchema) from 10.0.19 to 10.0.20. - [Release notes](https://github.com/rsuter/NJsonSchema/releases) - [Commits](https://github.com/rsuter/NJsonSchema/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Style fixes for CimAsyncOperations (PowerShell#9945) * Improve release testing Docker images (PowerShell#9942) * Remove some Travis-CI references (PowerShell#9919) * Fix minor typos in code comments (PowerShell#9917) * Indentation fixes in ci.psm1 (PowerShell#9947) * Update readme gitter badge (PowerShell#9920) * Display com method signature with argument names (PowerShell#9858) * Display Duration when displaying `HistoryInfo` (PowerShell#9751) * Remove dead code about 'IsTransparentProxy' (PowerShell#9966) * Fix style issues from last commits (PowerShell#9937) * Suppress sporadic exceptions from JumpList creation code (PowerShell#9928) * Remove EtwActivity empty constructor and make minor style fixes (PowerShell#9958) * Sync docs changes into the embedded help for pwsh (PowerShell#9952) * Fix amazonlinux install script (PowerShell#9967) * Fix wrong comparison in CertificateProvider (PowerShell#9987) * Cleanup Parser tests (PowerShell#9792) Co-Authored-By: Ilya <darpa@yandex.ru> * Remove LCIDToLocaleName P/Invoke from GetComputerInfoCommand (PowerShell#9716) - Remove LCIDToLocaleName P/Invoke with StringBuilder - Reduce allocations by using GetCultureInfo to get cached CultureInfo - Use UInt32.TryParse to parse Hex - Minor cleanups after above changes * Fix gulp versions (PowerShell#9916) * Add quick steps for adding docs to cmdlets (PowerShell#9978) * Cleanup: Use EndsWith(char) and StartsWith(char) (PowerShell#9994) * Add test for `New-Item -Force` (PowerShell#9971) * Allow methods to be named after keywords (PowerShell#9812) * Move consts and methods to single CharExtensions class (PowerShell#9992) * Build(deps): Bump ThreadJob from 1.1.2 to 2.0.1 in /src/Modules (PowerShell#10003) * Code cleanup: use IndexOf(char) overload (PowerShell#9722) - Use IndexOf(char) overload instead of IndexOf(string) to benefit from Ordinal search - Replace IndexOf with Contains to get more understandable code - Use StringComparison.Ordinal for ASCII chars * Add automated RPM signing to release build (PowerShell#10013) * Download latest version (6.2.0) of PSDesiredStateConfiguration nuget package. (PowerShell#9932) * Update copyright symbol for NuGet packages (PowerShell#9936) * Avoid the `int[]` and `int[,]` allocation when tokenizing line comments and matching wildcard pattern (PowerShell#10009) - Reusing the same 2-dimensional integer array for processing line comments in the same Tokenizer. - Use ArrayPool<int> in PatternPositionVisitor to avoid creating transient int[]. * Bump NJsonSchema from 10.0.20 to 10.0.21 (PowerShell#10017) Bumps [NJsonSchema](https://github.com/rsuter/NJsonSchema) from 10.0.20 to 10.0.21. - [Release notes](https://github.com/rsuter/NJsonSchema/releases) - [Commits](https://github.com/rsuter/NJsonSchema/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Consider `DBNull.Value` and `NullString.Value` the same as `$null` when comparing with `$null` and casting to bool (PowerShell#9794) - Adds `LanguagePrimitives.IsNullLike()` method to account for `DBNull.Value` and `NullString.Value` so that they can be considered the same as a null value where sensible in PowerShell. - Updates `-ne` and `-eq` binders to treat `DBNull.Value` and `NullString.Value` as equal to null/AutomationNull. - Update code paths for comparing objects in LanguagePrimitives to ensure consistency with how the `-eq` and `-ne` binders work when calling LanguagePrimitives methods to do the comparisons. - Make `LanguagePrimitives.IsNull()` and `LanguagePrimitives.IsNullLike()` public methods. - Added tests for null behaviours in `NullRepresentatives.Tests.ps1` * Start-PSBuild -Clean doeas not remove all untracked files (PowerShell#10022) * Avoid `Assembly.GetName()` in 'ClrFacade.GetAssemblies(string)' to reduce allocations of 'CultureInfo' objects (PowerShell#10024) * Use AddRange in GetModules() (PowerShell#9975) * Add fast path for wildcard patterns that contains no wildcard characters (PowerShell#10020) * Set request headers when request body is empty in Web Cmdlets (PowerShell#10034) * Suppress PossibleIncorrectUsageOfAssignmentOperator rule violation by adding extra parenthesis (PowerShell#9460) * Use `AddOrUpdate()` instead of `Remove` then `Add` to register runspace (PowerShell#10007) * Reduce allocations in NavigationCmdletProvider.NormalizePath() (PowerShell#10038) * Indent fix in markdown-link.tests.ps1 (PowerShell#10049) * Use a static cache for `PSVersionInfo.PSVersion` to avoid casting `SemanticVersion` to `Version` very time accessing that property (PowerShell#10028) * Bump Markdig.Signed from 0.17.0 to 0.17.1 (PowerShell#10062) * Cleanup workflow code (PowerShell#9638) * Remove WorkFlowInfo type * Remove condition for UseSharedProcess * Remove PSWorkflowJob condition * Remove workflow from ValidateSet * Remove workflow from CommandTypes enum * Remove workflow from EventManager * Remove workflow from Get-Help * Remove WorkflowFileExtension ".xaml" from ModuleIntrinsics * Remove WorkflowFileExtension ".xaml" from ModuleCmdletBase * Remove workflow from PSModuleInfo * Remove workflow from CustomShellCommands * Remove workflow from InitialSessionStateProvider * Remove WriteWorkflowDebugNotSupportedError() * Remove unneeded resource strings from Module.cs * Remove xaml from valid extension list * Add to /etc/shells on macOS (PowerShell#10066) Co-Authored-By: Robert Holt <rjmholt@gmail.com> * Check if a reparsepoint is a symlink before trying to get target (PowerShell#9895) * Make `Foreach-Object` 2 times faster by reducing unnecessary allocations and boxing (PowerShell#10047) * Update 'Start-PSBuild -Clean' logic of 'git clean' to ignore locked files from VS2019 (PowerShell#10071) * Create JumpList in STA thread as some COM APIs are strictly STA only to avoid sporadic CLR crashes (PowerShell#10057) * Upgrade .Net Core 3 SDK from preview5 to preview6 and related out of band Nuget packages from 2.1 to 3.0-preview6 (PowerShell#9888) * Bump PackageManagement from 1.4.2 to 1.4.3 in /src/Modules (PowerShell#10084) Bumps PackageManagement from 1.4.2 to 1.4.3. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * add performance tag to change log command * Bump PowerShellGet from 2.1.5 to 2.2 in /src/Modules (PowerShell#10085) Bumps [PowerShellGet](https://github.com/PowerShell/PowerShellGet) from 2.1.5 to 2.2. - [Release notes](https://github.com/PowerShell/PowerShellGet/releases) - [Changelog](https://github.com/PowerShell/PowerShellGet/blob/development/CHANGELOG.md) - [Commits](https://github.com/PowerShell/PowerShellGet/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Move some of the creations of `WildcardPattern` in outer loop to avoid unnecessary allocation (PowerShell#10053) * Add another fast path to `WildcardPattern.IsMatch` for patterns that only have an asterisk in the end (PowerShell#10054) * Update change log generation tool to deal with private commits (PowerShell#10096) * Bump System.Text.Encoding.CodePages (PowerShell#10112) Bumps System.Text.Encoding.CodePages from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Security.AccessControl (PowerShell#10100) Bumps System.Security.AccessControl from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Threading.AccessControl (PowerShell#10106) Bumps System.Threading.AccessControl from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Data.SqlClient (PowerShell#10109) Bumps System.Data.SqlClient from 4.7.0-preview6.19303.8 to 4.7.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Management (PowerShell#10110) Bumps System.Management from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.DirectoryServices (PowerShell#10105) Bumps System.DirectoryServices from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Security.Cryptography.Pkcs (PowerShell#10107) Bumps System.Security.Cryptography.Pkcs from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.IO.Packaging (PowerShell#10108) Bumps System.IO.Packaging from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Security.Principal.Windows (PowerShell#10101) Bumps System.Security.Principal.Windows from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Security.AccessControl (PowerShell#10102) Bumps System.Security.AccessControl from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Configuration.ConfigurationManager (PowerShell#10111) Bumps System.Configuration.ConfigurationManager from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Add -SecurityDescriptorSddl parameter to Set-Service (PowerShell#8626) * Bump System.Text.Encodings.Web (PowerShell#10123) Bumps System.Text.Encodings.Web from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Revert "Bump System.IO.Packaging (PowerShell#10108)" (PowerShell#10125) This reverts commit 45edbd7. * Revert "Bump System.Data.SqlClient (PowerShell#10109)" (PowerShell#10126) This reverts commit 83d8ec4. * Revert "Bump System.Threading.AccessControl (PowerShell#10106)" (PowerShell#10127) This reverts commit a7f0c6d. * Revert "Bump System.Text.Encodings.Web (PowerShell#10123)" (PowerShell#10124) This reverts commit b9501d9. * Revert "Bump System.Management (PowerShell#10110)" (PowerShell#10129) This reverts commit e5990ed. * Revert "Bump System.Security.Cryptography.Pkcs (PowerShell#10107)" (PowerShell#10130) This reverts commit d33c906. * Revert "Bump System.Text.Encoding.CodePages (PowerShell#10112)" (PowerShell#10131) This reverts commit 958cdda. * Revert "Bump System.Security.AccessControl (PowerShell#10102)" (PowerShell#10132) This reverts commit 729a29a. * Revert "Bump System.Configuration.ConfigurationManager (PowerShell#10111)" (PowerShell#10128) This reverts commit c8fe894. * Revert "Bump System.Security.Principal.Windows (PowerShell#10101)" (PowerShell#10133) This reverts commit f75c635. * Cleanup workflow - remove PSProxyJob (PowerShell#10083) * Revert "Bump System.DirectoryServices (PowerShell#10105)" (PowerShell#10135) This reverts commit 2852efc. # Conflicts: # src/System.Management.Automation/System.Management.Automation.csproj * Fix test password generation rule to meet Windows complexity requirements (PowerShell#10143) * Cleanup CompiledScriptBlock.cs (PowerShell#9735) * Add alias for Service 'StartType' (PowerShell#9940) * Mark Set-Service tests with password as `Pending` (PowerShell#10146) * Split the fxdependent package on Windows into two packages (PowerShell#10134) * Remove 'kill' alias for Stop-Process cmdlet on Unix (PowerShell#10098) * Identify renaming a parameter set as non-breaking in the breaking change contract document (PowerShell#10113) * Identify renaming a parameter set as non-breaking Related discussion: PowerShell#10058. * Add note about S.M.A.Internal * Update DotNet Support links (PowerShell#10145) * Remove `markdownlint` tests due to security issues (PowerShell#10163) * Remove `markdownlint` tests due to security issues (PowerShell#10163) * Merged PR 5767: Fix RegEx DoS issues Fix RegEx DoS issues * Skip `JumpList` on `NanoServer` and `IoT` (PowerShell#10164) * Skip `JumpList` on `NanoServer` and `IoT` (PowerShell#10164) * Merged PR 9185: Update PowerShell SDK version for hosting tests Update PowerShell SDK version for hosting tests * Merged PR 9168: Disable Enter-PSHostProcess cmdlet when system in lock down mode This is based on an issue, where Enter-PSHostProcess on a locked down (WDAC enforced) machine allows any admin to connect to any another local hosted PowerShell process and execute commands as that user. This amounts to privilege escalation on the policy locked down machine and something we want to prevent. Fix is to check for system lock down and disable Enter-PSHostProcess cmdlet with an error message. * Update README.md and metadata.json for next releases (PowerShell#10087) * Add tooling section to PR template (PowerShell#10144) * Add .devcontainer configuration (PowerShell#10114) * Add the license header to `nanoserver.tests.ps1` (PowerShell#10171) * Refactor security policy documentation so that they appear in the Security policy tab of GitHub (PowerShell#9905) Co-Authored-By: Travis Plunk <travis.plunk@microsoft.com> * PSSA also includes formatting (PowerShell#10172) * Merged PR 9166: Update changelog for v7.0.0-preview.2 Update changelog for v7.0.0-preview.2 Updates are expected when STA / MTA change comes in. * Fix hungarian prefix 'my' (PowerShell#9976) * Update docs for `7.0.0-preview.2` release (PowerShell#10160) * Update release date for `v7.0.0-preview.2` (PowerShell#10176) * Reduce allocations in Escape() and Unescape() (PowerShell#10041) * Add -Raw switch to Select-String for convenience (PowerShell#9901) * Avoid boxing when passing value type arguments to `PSTraceSource.WriteLine` (PowerShell#10052) * Fix macOS build break (PowerShell#10207) * Use nameof() in LocationGlobber and PathInfo (PowerShell#10200) * Use nameof() in LocationGlobber * Use nameof() in PathInfo * Fix: Removed dependency file with Dependabot (PowerShell#10212) * Enable `-sta` and `-mta` switches for pwsh (PowerShell#10061) * Use 'Platform.IsWindowsDesktop' instead of checking both NanoServer and IoT (PowerShell#10205) * Special case the posix locale in WildcardPattern (PowerShell#10186) * Quote arguments in `.vscode/tasks.json` in case of spaces (PowerShell#10204) * Create`Distribution_Request` issue template (PowerShell#10253) * Fix spelling error in issue template (PowerShell#10256) * Revert the temporary change (PowerShell#10260) * Bump Microsoft.CodeAnalysis.CSharp from 3.1.0 to 3.2.0 (PowerShell#10273) Bumps [Microsoft.CodeAnalysis.CSharp](https://github.com/dotnet/roslyn) from 3.1.0 to 3.2.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Cleanup: ThreadAbortException is now in .Net Core 3.0 (PowerShell#10230) * Cleanup: ThreadAbortException is now in .Net Core 3.0 * Fix CodeFactor issue * Remove ThreadAbortException * Remove ThreadAbortException relared code * Remove stable and servicing branches from dependabot (PowerShell#10289) * Update dead links from powershell.com (PowerShell#10297) * Remove extra check that the system dll exists (PowerShell#10244) * Update PowerShell to build against .NET Core 3.0-preview7 (PowerShell#10227) * Fix debugger disable performance regression (PowerShell#10269) * Don't collect process starttime as it's not being used on consolehost startup (PowerShell#10294) * mark _readyForInputTimeInMS member as part of LEGACYTELEMETRY * move _interactiveCommandCount to LEGACYTELEMETRY * Cleanup Docker release testing (PowerShell#10310) * Update our language on our policy applying to security issues (PowerShell#10304) * Add tests for WildcardPattern.Escape() and Unescape() (PowerShell#10090) * Update 'Microsoft.PowerShell.CoreCLR.Eventing' to resolve conflict with 'System.Diagnostics.EventLog' (PowerShell#10305) * Update 'Microsoft.PowerShell.CoreCLR.Eventing' to resolve conflicts * Add reference to 'System.Diagnostics.EventLog' to build Microsoft.PowerShell.Commands.Diagnostics on Unix * Stop compiling Get/New-WinEvent on Unix * Enable Experimental Features by default on Preview builds (PowerShell#10228) * Bump Microsoft.CodeAnalysis.CSharp from 3.2.0 to 3.2.1 (PowerShell#10330) Bumps [Microsoft.CodeAnalysis.CSharp](https://github.com/dotnet/roslyn) from 3.2.0 to 3.2.1. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Expose PreRelease label in PSModuleInfo formatter (PowerShell#10316) * Reduce allocations in MakePath() method (PowerShell#10027) * Add `Microsoft.PowerShell.CoreCLR.Eventing.dll` to exception list for build fix (PowerShell#10337) * Add dispose of _runspaceDebugCompleteEvent event object. (PowerShell#10323) * Make module name matching for `get-module -FullyQualifiedName`… (PowerShell#10329) * Fix `#requires -version` for pwsh 7 to include 6.1 and 6.2 in `PSCompatibleVersions` (PowerShell#9943) * Implement ForEach-Object -Parallel feature (PowerShell#10229) * Add support for AppX reparse points (PowerShell#10331) * Make Get-DscResource work with class based resources (PowerShell#10350) * pwsh -Login support (PowerShell#10050) * Deprecate internal HelpCategory.Workflow enumeration (PowerShell#10319) * Fix style issues in InternalCommands.cs (PowerShell#10352) * Deprecate workflow debugging code (PowerShell#10321) * Bump NJsonSchema from 10.0.21 to 10.0.22 (PowerShell#10364) Bumps [NJsonSchema](https://github.com/RicoSuter/NJsonSchema) from 10.0.21 to 10.0.22. - [Release notes](https://github.com/RicoSuter/NJsonSchema/releases) - [Commits](https://github.com/RicoSuter/NJsonSchema/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Move to .NET Core 3.0 preview.8 (PowerShell#10351) * Update Microsoft.Management.Infrastructure version to 2.0.0-preview.2 (PowerShell#10366) * Mark `-parallel` and `-throttlelimit` reserved for `foreach` and `switch` statements (PowerShell#10328) * Fix minor breakpoint re-hydration bug (PowerShell#10339) * Additional Telemetry - Implementation of `RFC0036` (PowerShell#10336) * Formatting: Handle `XTPUSHSGR` and `XTPOPSGR` control sequences (PowerShell#10208) * .CPL should be added to PATHEXT (PowerShell#9828) * Add experimental check for `ForEach-Object -Parallel` tests (PowerShell#10354) * Bump `PackageManagement` from `1.4.3` to `1.4.4` (PowerShell#10383) Bumps PackageManagement from 1.4.3 to 1.4.4. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump PowerShellGet from 2.2 to 2.2.1 in /src/Modules (PowerShell#10382) Bumps [PowerShellGet](https://github.com/PowerShell/PowerShellGet) from 2.2 to 2.2.1. - [Release notes](https://github.com/PowerShell/PowerShellGet/releases) - [Changelog](https://github.com/PowerShell/PowerShellGet/blob/development/CHANGELOG.md) - [Commits](https://github.com/PowerShell/PowerShellGet/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Merged PR 9744: Update changelog for preview.3 release Update changelog for preview.3 release * Update `README.md` and `metadata.json` for `7.0.0-preview.3` (PowerShell#10393) * Add `PSKoans` to Learning Resources documentation (PowerShell#10369) * Add some regular contributors to allow access to retry CI (PowerShell#10397) * Some dependencies for Alpine need `linux-x64` folder (PowerShell#10407) * Block type update in Add-Type cmdlet (PowerShell#9609) * Increase built-with-PowerShell module versions to 7.0.0.0 (PowerShell#10356) * Rename default ParameterSetName back to `Delimiter` for `ConvertTo-Csv` & `ConvertFrom-Csv` (PowerShell#10425) * rename default parameterset name back to `Delimiter` * also fix convertfrom-csv * rename parametersetname for UseCulture back to UseCulture since there is no path for ConvertFrom-Csv * Skip auto-loading PSReadLine on Windows if the NVDA screen reader is active (PowerShell#10385) * Bump NJsonSchema from 10.0.22 to 10.0.23 (PowerShell#10421) Bumps [NJsonSchema](https://github.com/RicoSuter/NJsonSchema) from 10.0.22 to 10.0.23. - [Release notes](https://github.com/RicoSuter/NJsonSchema/releases) - [Commits](https://github.com/RicoSuter/NJsonSchema/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Add support to `ActionPreference.Break` to break into debugger (PowerShell#8205) * Alpine validation changes (PowerShell#10428) * Remove yet another appveyor reference (PowerShell#10445) * Update the combined package build to release the daily builds (PowerShell#10449) * Cleanup `AutomationEngine` and remove extra `SetSessionStateDrive` method call (PowerShell#10416) * Make sure the daily coordinated build, knows it is a daily bui… (PowerShell#10464) * Minor fix for recursion into OneDrive - Change FindFirstFileEx() to use SafeFindHandle type (PowerShell#10405) * Update README.md (PowerShell#10465) Fix typo. * Make `ForEach-Object` faster for its commonly used scenarios (PowerShell#10454) * Fix global tool issues around exit code, command line parameters and path with spaces (PowerShell#10461)

bergmeister added 2 commits June 13, 2019 17:56

Upgrade .Net Core 3 SDK from preview5 to preview6 and keep NuGet pack…

bc7a14a

…age Microsoft.AspNetCore.Mvc.NewtonsoftJson used for testing in sync with it

Fix namespace ambiguity between 'System.Management.Automation.AllowNu…

0cecfe2

…llAttribute' and 'System.Diagnostics.CodeAnalysis.AllowNullAttribute and cleanup some unused usings.

This comment has been minimized.

Sign in to view

Fix MSI installer by adding the new DLLs

5fbd549

This comment has been minimized.

Sign in to view

iSazonov reviewed Jun 14, 2019

View reviewed changes

Revert accidental change in SMA for NonBlockingRead

3b79c82

iSazonov requested review from SteveL-MSFT and daxian-dbw June 14, 2019 10:57

Fix Startup.Tests.ps1 expectations to expect System.Security.Cryptogr…

0c46bfa

…aphy.Primitives.dll and System.Security.Principal.dll to be only loaded on Windows

bergmeister marked this pull request as ready for review June 15, 2019 11:49

bergmeister requested review from JamesWTruher, PaulHigin, TravisEz13, adityapatwardhan and anmenaga as code owners June 15, 2019 11:49

bergmeister added 3 commits June 17, 2019 08:10

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

4449e78

…o netcore3.0-preview6

Upgrade all NuGet packages except for System.ServiceProcess.ServiceCo…

2b8add4

…ntroller and Microsoft.Windows.Compatibility (which depends on it)

Update web listener package as well

d68ac15

PoshChan reviewed Jul 1, 2019

View reviewed changes

assets/files.wxs Show resolved Hide resolved

PoshChan reviewed Jul 1, 2019

View reviewed changes

assets/files.wxs Show resolved Hide resolved

bergmeister added 3 commits July 2, 2019 19:18

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

e244175

…o netcore3.0-preview6

Revert "Update System.ServiceProcess.ServiceController and Microsoft.…

c86f14a

…Windows.Compatibility (which has a dependency on it). This will make 2 tests fail on Windows:" This reverts commit b518c73.

Fix installer by removing redundant System.Data.OleDb.dll entry

fd7e52a

daxian-dbw requested changes Jul 2, 2019

View reviewed changes

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 2, 2019

ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 3, 2019

SteveL-MSFT assigned daxian-dbw Jul 5, 2019

Remove SuppressMessage attributes to make calls to AllowNullAttribute…

3c764ee

… unique in terms of namespace to avoid having to add special static using statements as per code review. Also remove one redundant using statement

daxian-dbw approved these changes Jul 5, 2019

View reviewed changes

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

866e27e

…o netcore3.0-preview6 Re-hydrate files.wxs # Conflicts: # assets/files.wxs

iSazonov approved these changes Jul 6, 2019

View reviewed changes

daxian-dbw merged commit fe56f9d into PowerShell:master Jul 9, 2019

TravisEz13 added this to the 7.0.0-preview.2 milestone Jul 9, 2019

TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jul 9, 2019

ghost mentioned this pull request Jul 17, 2019

v7.0.0-preview.1: can't cast string to [WMIClass] anymore #9780

Closed

Upgrade .Net Core 3 SDK from preview5 to preview6 and related out of band Nuget packages from 2.1 to 3.0-preview6 #9888

Upgrade .Net Core 3 SDK from preview5 to preview6 and related out of band Nuget packages from 2.1 to 3.0-preview6 #9888

Uh oh!

Conversation

bergmeister commented Jun 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bergmeister commented Jun 13, 2019 • edited by daxian-dbw Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SteveL-MSFT commented Jun 13, 2019

Uh oh!

bergmeister commented Jun 13, 2019

Uh oh!

iSazonov Jun 14, 2019

Choose a reason for hiding this comment

Uh oh!

bergmeister Jun 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SteveL-MSFT Jul 1, 2019

Choose a reason for hiding this comment

Uh oh!

daxian-dbw Jul 2, 2019

Choose a reason for hiding this comment

Uh oh!

daxian-dbw Jul 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iSazonov Jun 14, 2019

Choose a reason for hiding this comment

Uh oh!

bergmeister Jun 14, 2019

Choose a reason for hiding this comment

Uh oh!

iSazonov Jun 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bergmeister Jun 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iSazonov Jun 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bergmeister Jun 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bergmeister commented Jun 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SteveL-MSFT commented Jun 14, 2019

Uh oh!

bergmeister commented Jun 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iSazonov commented Jun 15, 2019

Uh oh!

bergmeister commented Jun 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iSazonov commented Jun 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SteveL-MSFT commented Jul 1, 2019

Uh oh!

bergmeister commented Jul 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

bergmeister commented Jun 13, 2019 •

edited

Loading

bergmeister commented Jun 13, 2019 •

edited by daxian-dbw

Loading

bergmeister Jun 14, 2019 •

edited

Loading

daxian-dbw Jul 5, 2019 •

edited

Loading

iSazonov Jun 14, 2019 •

edited

Loading

bergmeister Jun 15, 2019 •

edited

Loading

iSazonov Jun 15, 2019 •

edited

Loading

bergmeister Jun 16, 2019 •

edited

Loading

bergmeister commented Jun 14, 2019 •

edited

Loading

bergmeister commented Jun 15, 2019 •

edited

Loading

bergmeister commented Jun 15, 2019 •

edited

Loading

iSazonov commented Jun 17, 2019 •

edited

Loading

bergmeister commented Jul 1, 2019 •

edited

Loading

bergmeister commented Jul 2, 2019 •

edited

Loading

bergmeister commented Jul 5, 2019 •

edited

Loading