[PT Inductor] Add parsing grouped conv fwd instances #1585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenpercent
requested review from
aosewski,
bartekxk,
carlushuang,
geyyer,
illsilin,
junliume and
poyenc
as code owners
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Oct 22, 2024
#137947) Plug into lowering and end to end test in a later PR Instance parsing companion PR ROCm/composable_kernel#1585 Pull Request resolved: #137947 Approved by: https://github.com/ColinPeppler, https://github.com/chenyang78
illsilin
approved these changes
Oct 25, 2024
SamGinzburg
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Oct 28, 2024
#137947) Plug into lowering and end to end test in a later PR Instance parsing companion PR ROCm/composable_kernel#1585 Pull Request resolved: #137947 Approved by: https://github.com/ColinPeppler, https://github.com/chenyang78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds instance parsing logic for grouped convolution forward CK instances, similar to the existing Universal Gemm instances
Also add missing license headers and format everything with Ruff on default settings
Companion to pytorch/pytorch#137947 but can be merged independently, since it doesn't modify the parsing logic for Universal Gemms