fix: permission input handling #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
approved these changes
May 2, 2025
|
@parkerbxyz make sure the PR closes #237 and comment on #236 and close the discussion |
parkerbxyz
changed the title
create-app-token-action-releaser bot
pushed a commit
that referenced
this pull request
May 2, 2025
## [2.0.4](v2.0.3...v2.0.4) (2025-05-02) ### Bug Fixes * permission input handling ([#243](#243)) ([2950cbc](2950cbc))
|
🎉 This PR is included in version 2.0.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the handling of permissions inputs.
getPermissionsFromInputsinlib/get-permissions-from-inputs.jsto use hyphens (INPUT_PERMISSION-) instead of underscores (INPUT_PERMISSION_) in input keys, added a check to skip empty values, and clarified behavior when no permissions are set.shouldRetryfunction to retry requests when server errors (HTTP status 500 or higher) occur in themainfunction inlib/main.jsto prevent unnecessary retries.tests/main-token-permissions-set.test.jsto match the new input key format with hyphens.INPUT_PERMISSION-ADMINISTRATION) intests/main.jsto simulate the behavior of the Actions runner.tests/snapshots/index.js.mdto reflect the updated hyphenated input keys in permissions.