KEMBAR78
Mark action download failures as infra failures by cory-miller · Pull Request #2827 · actions/runner · GitHub
Skip to content

Conversation

@cory-miller
Copy link
Contributor

When the tar/zip is corrupted, it is most likely due to an infrastructure failures on the GitHub side. We will mark these failures so that it shows up as such in internal metrics.

@cory-miller cory-miller requested a review from a team as a code owner September 5, 2023 20:31
Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>
Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cory-miller cory-miller enabled auto-merge (squash) September 6, 2023 13:17
@cory-miller cory-miller merged commit 7b703d6 into main Sep 6, 2023
@cory-miller cory-miller deleted the users/cory-miller/infra-failures-codeload branch September 6, 2023 13:32
ashb pushed a commit to ashb/runner that referenced this pull request Sep 7, 2023
* Mark action download failures as infra failures

* Fix Windows variable name

* Update src/Runner.Worker/ActionManager.cs

Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>

---------

Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants