Fix if statement structure in update script and variable reference #3956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
previously approved these changes
Jul 25, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a syntax error in the update script by adding a missing fi statement to properly close an if block. The change ensures the shell script has correct conditional statement structure.
Key changes:
- Added missing
fistatement to close an if block in the update script template
salmanmkc
changed the title
TingluoHuang
approved these changes
Jul 25, 2025
salmanmkc
added a commit
that referenced
this pull request
Jul 25, 2025
LouisHaftmann
pushed a commit
to falcondev-oss/github-actions-runner
that referenced
this pull request
Aug 3, 2025
This was referenced Aug 14, 2025
fmartinez255
pushed a commit
to TiVo/actions-runner
that referenced
this pull request
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the structure of an if statement in the update script to ensure proper execution flow.
Fixes #3955