KEMBAR78
no such method => modified function args by phinzphinz · Pull Request #16610 · apache/mxnet · GitHub
Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

no such method => modified function args #16610

Merged
merged 3 commits into from
Oct 30, 2019
Merged

no such method => modified function args #16610

merged 3 commits into from
Oct 30, 2019

Conversation

@phinzphinz
Copy link
Contributor

@phinzphinz phinzphinz commented Oct 24, 2019 •
edited by iblislin
Loading 

ERROR: MethodError: no method matching mapreduce(::getfield(MXNet.mx, Symbol("##8072#8073")), ::typeof(+), ::Float64, ::Array{NDArray{Float32,1},1})

Description

The Julia regression example did not run due to an inappropriate call of the mapreduce function when usen MSE() loss.

Changes

  • Changed the use of the mapreduce function to remove the error

@phinzphinz phinzphinz requested a review from iblislin as a code owner October 24, 2019 19:22
iblislin
iblislin reviewed Oct 25, 2019
View reviewed changes
julia/deps/build.jl
if nvcc_path ≢ nothing
@info "Found nvcc: $nvcc_path"
push!(CUDAPATHS, replace(nvcc_path, "bin/nvcc", "lib64"))
push!(CUDAPATHS, replace(nvcc_path, "bin/nvcc" => "lib64"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I have a PR that fixed the building issues #16125

Copy link
Contributor Author

@phinzphinz phinzphinz Oct 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Then this PR can be ignored.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 ... we still can get this merged into master first.

@iblislin iblislin added the Julia label Oct 25, 2019
iblislin
iblislin reviewed Oct 26, 2019
View reviewed changes
iblislin
iblislin approved these changes Oct 26, 2019
View reviewed changes
julia/deps/build.jl
if nvcc_path ≢ nothing
@info "Found nvcc: $nvcc_path"
push!(CUDAPATHS, replace(nvcc_path, "bin/nvcc", "lib64"))
push!(CUDAPATHS, replace(nvcc_path, "bin/nvcc" => "lib64"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 ... we still can get this merged into master first.

@iblislin
Copy link
Member

I accidentally hit the 'Approve" button 😂

@iblislin
Copy link
Member

The CI faliure is unrelated, but the merge button is locked because of it.
Could you rebase your PR to re-trigger CI?

@phinzphinz
Copy link
Contributor Author

I am no git expert and followed this tutorial. I hope I did everything right.

@iblislin
Copy link
Member

ah, the test failure will be fixed by #16643.
maybe we can wait until that patch got merged.

Here are steps to rebasing:

  1. First, switch to this PR branch.
    then, add this repo as a remote.
git remote add upstream https://github.com/apache/incubator-mxnet.git

  1. And verify it via git remote -v.

  2. Fetch the code git fetch upstream

  3. rebase: git rebase upstream/master

  4. git push -f # force push, since we changed the commit hash.

@phinzphinz
Copy link
Contributor Author

phinzphinz commented Oct 27, 2019 •
edited
Loading

Thanks for the steps. I followed them. Yes, we can wait for the other patch.

@iblislin
Copy link
Member

Okay, that PR (#16643) got merged. Let's try again.

phinzphinz and others added 3 commits October 28, 2019 20:48
@phinzphinz @Gobutah
no such method => modified function args
d25d752 
ERROR: MethodError: no method matching mapreduce(::getfield(MXNet.mx, Symbol("#apache#8072#8073")), ::typeof(+), ::Float64, ::Array{NDArray{Float32,1},1})
@phinzphinz @Gobutah
julia could not build package before
b9f8db0
@phinzphinz @iblislin @Gobutah
Update julia/src/metric.jl
a01a9ee 
Co-Authored-By: Iblis Lin <iblis@hs.ntnu.edu.tw>
@marcoabreu marcoabreu merged commit 8e50fd9 into apache:master Oct 30, 2019
yajiedesign pushed a commit to yajiedesign/mxnet that referenced this pull request Nov 6, 2019
@phinzphinz @iblislin @yajiedesign
no such method => modified function args (apache#16610)
2c78cc3 
* no such method => modified function args

ERROR: MethodError: no method matching mapreduce(::getfield(MXNet.mx, Symbol("#apache#8072#8073")), ::typeof(+), ::Float64, ::Array{NDArray{Float32,1},1})

* julia could not build package before

* Update julia/src/metric.jl

Co-Authored-By: Iblis Lin <iblis@hs.ntnu.edu.tw>
@drrmmng drrmmng mentioned this pull request Mar 9, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@iblislin iblislin iblislin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Julia

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phinzphinz @iblislin @marcoabreu