[Unity, BYOC] Add check for leaking intemediate variables for cublas and cudnn #16175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinx13
force-pushed
the
unity-cublas-leaky
branch
from
0964549 to
06cba4a
Compare
masahi
reviewed
Nov 29, 2023
| with R.dataflow(): | ||
| w1: R.Tensor((16, 16), dtype="float16") = R.permute_dims(w, axes=None) | ||
| y: R.Tensor((1, 16), dtype="float16") = R.matmul(x, w1) | ||
| y1: R.Tensor((1, 16), dtype="float16") = y |
There was a problem hiding this comment.
I think such binding can be removed by CanonicalizeBinding pass
masahi
approved these changes
Nov 29, 2023
Archermmt
pushed a commit
to Archermmt/tvm
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks to prevent cyclic dependency between groups during fusion
cc @masahi @Hzfengsy