Add Availability Annotations #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nathantannar4
commented
Dec 2, 2022
nathantannar4
commented
- Add availability annotations rather than limiting package availability to iOS 16 / macOS 12. This is necessary for anyone who wants to incorporate this package in an existing app that needs to support older platforms, since weak linking a Swift package is not possible.
|
Thank you for your interest in contributing to Core ML Stable Diffusion! Please review CONTRIBUTING.md. If you would like to proceed with this pull request, please indicate your agreement to the terms outlined in CONTRIBUTING.md by checking the box below. We appreciate your interest in the project!
|
|
|
Hi @nathantannar4! Thanks again for putting up this PR. We having a few other PRs in flight at the moment so please bear with us as we figure out the best ordering. The latest change introduced some conflicts and new symbols that will also need availability annotations. It would be great if you can update this PR to resolve those. Thanks! |
|
No problem, revised |
alejandro-isaza
approved these changes
Dec 14, 2022
msiracusa
approved these changes
Dec 14, 2022
Closed
takeyat
pushed a commit
to takeyat/ml-stable-diffusion
that referenced
this pull request
Dec 25, 2022
* commit 'e07c4d00c387840f70fa3701fb3a51c2a32f37b8': Move guidanceScale as generation parameter (apple#46) Add brief instructions to download weights from the Hub (apple#10) Adds Negative Prompts (apple#61) Changed seed type into UInt32 (apple#47) fixes apple#77 Update README.md (apple#66) Add Filename Character Limit (apple#19) Implement DPM-Solver++ scheduler (apple#59) Fix typos: Successfully facilitate getting pipeline overridden (apple#30) Undefined name: from typing import List (apple#31) Add Availability Annotations (apple#18) README improvements and reduceMemory option in Swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.