Increase setup_lib_path buf size to PATH_MAX #1049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apangin
reviewed
Nov 8, 2024
src/main/main.cpp
Outdated
| #include "fdtransferServer.h" | ||
|
|
||
| #ifdef __linux__ | ||
| #include <linux/limits.h> |
There was a problem hiding this comment.
There is a platform independent version: <limits.h>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Buffer smaller than
PATH_MAXwould cause silent truncation when path length is larger than the buffer size.Motivation and context
To eliminate possible silent filename truncation, which may cause an error or surprising behavior.
How has this been tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.