Parse both .rela.dyn and .rela.plt of libraries. #1074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also parse R_X86_64_64 relocations in x86-64 builds.
apangin
reviewed
Dec 6, 2024
src/symbols_linux.cpp
Outdated
| # define R_DIRECT -1 | ||
| #elif defined(__aarch64__) | ||
| # define R_GLOB_DAT R_AARCH64_GLOB_DAT | ||
| # define R_DIRECT -1 |
There was a problem hiding this comment.
Isn't there an AArch64 equivalent?
I see it generates R_AARCH64_ABS64
There was a problem hiding this comment.
I originally added something for all archs, but given I cannot test them, I focused on x86-64. I can add it for arm64.
| } else if (rel != NULL && relsz != 0) { | ||
| } | ||
|
|
||
| if (rel != NULL && relsz != 0) { |
There was a problem hiding this comment.
Can the same function occur in multiple relocations? I believe it can. We don't necessarily need to handle such cases right now, but if this happens, .rela.plt should take precedence.
apangin
reviewed
Dec 6, 2024
src/symbols_linux.cpp
Outdated
| ElfSymbol* sym = (ElfSymbol*)(symtab + ELF_R_SYM(r->r_info) * syment); | ||
| if (sym->st_name != 0) { | ||
| _cc->addImport((void**)(base + r->r_offset), strtab + sym->st_name); | ||
| _cc->tryAddImport((void**)(base + r->r_offset), strtab + sym->st_name); |
There was a problem hiding this comment.
Maybe just switch the order of these two loops? This will ensure proper precedence automatically without 'override' logic in CodeCache?
This reverts commit 73c334a.
Signed-off-by: Andrei Pangin <1749416+apangin@users.noreply.github.com>
Signed-off-by: Andrei Pangin <1749416+apangin@users.noreply.github.com>
This was referenced Dec 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to have symbols in both
.rela.dynand.rela.pltsections, depending how the symbols are used. Furthermore,.rela.dyncan haveR_X86_64_64relocation type among others.async-profiler did not parse
.rela.dynsection if.rela.pltwas present.Support parsing
.rela.dynR_X86_64_64symbols and both.rela.dynand.rela.pltin the same ELF binary, to enable internal usage (hooking) of the imported functions.Related issues
#1060
Motivation and context
While investigating #1060 and the possible fix in #1065, noticed that
R_X86_64_64relocation type is not supported.How has this been tested?
New test added in
symbolsLinuxTest.cpp.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.