CI/CD: use runson.display for publishing test artifacts instead of runson.name #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krk
pushed a commit
to krk/async-profiler
that referenced
this pull request
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the latest commit merge, the "publish" step fails for nightly build. Ref: #1154 (comment)
Root cause: While downloading artifacts in the workflow, we filter the test files via
*.*regex. In the above PR, the name of the test artifacts uploaded contained24.04in the string (since it uses display.runson and we are forced to use24.04there). Thus, these test logs were not getting filtered and as a result, the Javascript which only expected files, also started seeing directories (of test artifacts) and thus the failure.This PR uses
runson.displayinstead ofrunson.nameto circumvent the issue.Related issues
#1154 (comment)
Motivation and context
In the PR #1154 we moved to GH hosted runners. After the merge, the publish step fails as noted in the link above.
This PR aims to fix that.
How has this been tested?
A successful run was tested here (in my fork branch): https://github.com/visheshruparelia/async-profiler/actions/runs/13634688113/job/38110523750
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.