Implement new '--inverted' option to flip graphs vertically #1178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apangin
reviewed
Mar 14, 2025
apangin
reviewed
Mar 15, 2025
|
Merged. Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AsyncProfiler currently supports two kind of graphs:
main()function) at the bottom and the innermost, leaf frames at the top. They are created from stack traces which are merged starting from the outermost (e.g.main()) frames.Both kind of graphs can be flipped vertically with the
Revertbutton which is located in the upper-left corner of the generated HTML page, when the graph is displayed.But normal/reverse stack traces and icicle/flame graphs are orthogonal settings. Both kind of stack traces can be flipped vertically. Unfortunately, the vertical orientation can currently only be changed in the generated HTML page but the default orientation can not be set when the graphs are generated. It always defaults to a bottom-up, flame graph layout for normal stack traces and a top-down, icicle layout for reverse stack traces.
This PR introduces a new command line parameter
--invertedwhich makes it possible to change the default vertical orientation for both kind of stack traces. The name of the parameter (i.e.invertedinstead ofinverse) is taken from Brendan Greg's original flamegraph.pl script which also provides this option.The PR doesn't change the default behavior of AsyncProfiler. Normal stack traces are still rendered as bottom-up flame graphs and reverse stack traces are still rendered as top-down icicle, graphs. But both of these defaults can now be changed with the new
--inverted=<true|false>command line option.Related issues
See the discussion on #82 for a similar request.
Motivation and context
See Description section.
How has this been tested?
make testand manual testing of the new parameter forasprof,jfrconvand the agent use case.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.