Allow specifying a target for CPU profiling #1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fandreuz
commented
Mar 14, 2025
fandreuz
changed the title
apangin
reviewed
Mar 14, 2025
fandreuz
commented
Mar 14, 2025
apangin
reviewed
Mar 14, 2025
apangin
reviewed
Mar 14, 2025
apangin
reviewed
Mar 18, 2025
apangin
reviewed
Mar 19, 2025
apangin
reviewed
Mar 19, 2025
|
Merged. |
krk
pushed a commit
to krk/async-profiler
that referenced
this pull request
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow users to select a specific CPU via
--target-cputo sample only threads running on that CPU. See #481 for the original issue.Related issues
#481, #919
Motivation and context
See original issues for use cases.
How has this been tested?
I introduced some tests in
test.cpu.CpuTests:perfEventsRightTargetCputests the number of events sampled when the right CPU is selected;perfEventsWrongTargetCputests the number of events sampled when the wrong CPU is selected;In order to introduce those tests, I had to add a small extension to the test infrastructure in order to allow pinning the newly started process to a specific CPU via
taskset.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.