KEMBAR78
Preferably patch non-dotted symbols when more than one matches the prefix by fandreuz · Pull Request #1251 · async-profiler/async-profiler · GitHub
Skip to content

Preferably patch non-dotted symbols when more than one matches the prefix #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 22, 2025
Merged

Preferably patch non-dotted symbols when more than one matches the prefix #1251

merged 6 commits into from
Apr 22, 2025

Conversation

fandreuz
Copy link
Contributor

@fandreuz fandreuz commented Apr 22, 2025 •
edited
Loading

Description

In this PR I implement the result of the discussion under #1247

Related issues

Fixes #1247
Needed by #1226

Motivation and context

Dotted symbols are generally less meaningful to be patched than dotted symbols.

How has this been tested?

make test-cpp and

docker run \
   -it --privileged --rm \
   -v $(pwd):/async-profiler amazoncorretto:11-alpine-jdk 
   sh -c 'apk add --no-cache musl-dev util-linux make gcc g++ linux-headers && \
      cd /async-profiler && \
      rm -rf build && \
      make -j test-java TESTS=jfr'

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@fandreuz fandreuz mentioned this pull request Apr 22, 2025
Merged
apangin
apangin reviewed Apr 22, 2025
View reviewed changes
@fandreuz fandreuz force-pushed the 1247-begin-end-patching branch from 6ea14d2 to 70494a5 Compare April 22, 2025 15:11
apangin
apangin reviewed Apr 22, 2025
View reviewed changes
@apangin apangin merged commit 14c7e81 into async-profiler:master Apr 22, 2025
19 of 20 checks passed
krk pushed a commit to krk/async-profiler that referenced this pull request Apr 25, 2025
@fandreuz @krk
Preferably patch non-dotted symbols when more than one matches the pr…
b43e28e 
…efix (async-profiler#1251)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apangin apangin apangin left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Options --begin and --end patch only the first occurrence of matching symbols

2 participants

@fandreuz @apangin