Detect and parse the loader in parseLibraries. #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use AT_BASE from auxv to get loader base address and parse it regardless of dlopen/dlerror results.
|
Unrelated flaky test failure: https://github.com/async-profiler/async-profiler/actions/runs/14646848652/job/41103103161?pr=1263 ref. #1232 |
apangin
reviewed
Apr 24, 2025
| std::unordered_map<u64, SharedLibrary> libs; | ||
| collectSharedLibraries(libs, MAX_NATIVE_LIBS - array->count()); | ||
|
|
||
| const char* ld_base = (const char*)getauxval(AT_BASE); |
Signed-off-by: Andrei Pangin <1749416+apangin@users.noreply.github.com>
krk
added a commit
to krk/async-profiler
that referenced
this pull request
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
AT_BASEfromauxvto get loader base address and parse it regardless of dlopen/dlerror results.Related issues
#1250
Motivation and context
The loader itself cannot be unloaded, so what dlopen/dlerror returns is not relevant. This simplifies and corrects the condition of calling
parseProgramHeaders.How has this been tested?
make testBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.