Thread name in OpenTelemetry output #1448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fandreuz
changed the title
apangin
reviewed
Aug 27, 2025
apangin
reviewed
Aug 28, 2025
test/test/otlp/OtlpTests.java
Outdated
| if (!threadName.isPresent()) continue; | ||
| threadNames.add(threadName.get().getStringValue()); | ||
| } | ||
| boolean cpuBurnerFound = threadNames.stream().anyMatch("CpuBurnerWorker"::equals); |
There was a problem hiding this comment.
Must-read post: https://medium.com/@tagir_valeev/use-stream-api-simpler-or-dont-use-it-at-all-ea0a44a4b1ff
Notably §1.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
thread.nameis an optionalSampleattribute. We can provide it when it is available.Related issues
#1436
Motivation and context
Will simplify testing of #1436.
How has this been tested?
New test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.