KEMBAR78
logger: catch up with logger::info interface change by wx257osn2 · Pull Request #1050 · cabinpkg/cabin · GitHub
Skip to content

logger: catch up with logger::info interface change #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2024
Merged

logger: catch up with logger::info interface change #1050

merged 1 commit into from
Dec 23, 2024
+3 −3

Conversation

wx257osn2
Copy link
Contributor

fixup for #1026, related #1034

This PR fixes diagnostics broken with #1026.

@ken-matsui ken-matsui changed the title Catchup to logger::info interface change logger: catch up with logger::info interface change Dec 23, 2024
ken-matsui
ken-matsui reviewed Dec 23, 2024
View reviewed changes
Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you.

@ken-matsui ken-matsui merged commit cabbdef into cabinpkg:main Dec 23, 2024
18 checks passed
@wx257osn2 wx257osn2 deleted the fix-diagnostics branch December 23, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ken-matsui ken-matsui ken-matsui left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wx257osn2 @ken-matsui