KEMBAR78
logger: use fmtlib by yaito3014 · Pull Request #1034 · cabinpkg/cabin · GitHub
Skip to content

logger: use fmtlib #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 16, 2024
Merged

logger: use fmtlib #1034

merged 6 commits into from
Nov 16, 2024

Conversation

yaito3014
Copy link
Contributor

@yaito3014 yaito3014 commented Nov 10, 2024 •
edited
Loading

fixes #1026

No change for Logger itself on initial commit.
I'm not sure whether it should be changed to use fmtlib.

ken-matsui
ken-matsui reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR.

No change for Logger itself on initial commit.
I'm not sure whether it should be changed to use fmtlib.

It's better for Logger::error etc. to have (almost) the same interface with logger::error.

ken-matsui
ken-matsui reviewed Nov 15, 2024
View reviewed changes
@ken-matsui ken-matsui changed the title change logging function to use fmtlib logger: use fmtlib Nov 15, 2024
@ken-matsui ken-matsui marked this pull request as ready for review November 16, 2024 00:56
ken-matsui
ken-matsui approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ken-matsui ken-matsui merged commit c1c5663 into cabinpkg:main Nov 16, 2024
16 checks passed
@ken-matsui ken-matsui mentioned this pull request Nov 16, 2024
Merged
@yaito3014 yaito3014 deleted the format-logger branch November 23, 2024 06:56
@wx257osn2 wx257osn2 mentioned this pull request Dec 22, 2024
Merged
ken-matsui pushed a commit that referenced this pull request Dec 23, 2024
@wx257osn2
logger: catch up with logger::info interface change (#1050)
cabbdef 
fixup for #1026, related #1034

This PR fixes diagnostics broken with #1026.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ken-matsui ken-matsui ken-matsui approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use fmt::format for loggers

2 participants

@yaito3014 @ken-matsui