Fix rendering non-false value sections #55
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 84.31% 84.77% +0.45%
==========================================
Files 2 2
Lines 440 440
==========================================
+ Hits 371 373 +2
+ Misses 46 44 -2
Partials 23 23 ☔ View full report in Codecov by Sentry. |
|
Thanks for pointing this out @roblillack. I updated to the latest spec tests in #56, which identified some problems. I believe if you rebase that change you should be able to remove the disabled tests in |
|
@cbroglie: Yep, that's looking good! |
|
Awesome, thank you |
This adds a bunch of fully integrated test sites. While here, fix some bugs: - Fix not being able to read `.md` or `.yaml` files instead of `.mkd` and `.yml`. #22 - Fix title casing. #3 - Fix iterate `siblings` in correct order. #4 - Fix crash for non-existent asset directories. #5 - Fix rendering section context. #8 (Needs cbroglie/mustache#54) - Fix rendering non-false value sections. #23 (Needs cbroglie/mustache#55) Also, add these features: - Allow the root index page to be defined with metadata and markup directly in `content/`. #19 - Add support for empty pages (no metadata or markup defined) if they have non-empty children. #20 - Add support for `children` to iterate non-floating child pages. #16 - Add support for `posts` to iterate all child pages marked with a date. #18 - Add support for `menu` sections to iterate all `siblings` and the current page (only for non-floating pages). #17 - For each entry of page collections (`children`, `menu`, `navigation`, `posts`, `siblings`) add `first` and `last` boolean values that can be used to construct better separators. #21
3 participants
This fixes rendering sections not backed by a slice, map or struct, but not false either.
According to the spec, this should work, so I fixed it and added a small test.
Sidenote: I think this should have been caught in
spec_test.go, but for some reason this test is not part of the tested.jsonfiles (it is part of the.yamlfiles in mustache/spec, though).