forked from checkstyle/checkstyle
-
Notifications
You must be signed in to change notification settings - Fork 0
Add support for html comment parsing #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Parent:
Setup for new parser
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnveach
reviewed
Aug 9, 2025
| | |--HTML_COMMENT_CONTENT -> HTML_COMMENT_CONTENT [0:6] | ||
| | | |--TEXT -> This is an HTML comment inside Javadoc. [0:6] | ||
| | | |--NEWLINE -> \n [0:46] | ||
| | | |--LEADING_ASTERISK -> * [1:0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still outstanding. Waiting on agreement from @nrmancuso .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
0db7bc6 to
027a36c
Compare
027a36c to
3589152
Compare
nrmancuso
approved these changes
Aug 10, 2025
rnveach
approved these changes
Aug 10, 2025
mahfouz72
added a commit
that referenced
this pull request
Sep 9, 2025
mahfouz72
added a commit
that referenced
this pull request
Sep 13, 2025
mahfouz72
added a commit
that referenced
this pull request
Sep 16, 2025
mahfouz72
added a commit
that referenced
this pull request
Sep 27, 2025
mahfouz72
added a commit
that referenced
this pull request
Sep 29, 2025
mahfouz72
added a commit
that referenced
this pull request
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #44