KEMBAR78
Update MissingWhitespaceAfterAsteriskCheck by mahfouz72 · Pull Request #64 · checkstyle-GSoC25/checkstyle · GitHub
Skip to content

Update MissingWhitespaceAfterAsteriskCheck #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Setup for new parser
merged 1 commit into from
Aug 16, 2025
Merged

Update MissingWhitespaceAfterAsteriskCheck #64

merged 1 commit into from
Aug 16, 2025

Conversation

@mahfouz72
Copy link
Collaborator

No description provided.

@mahfouz72 mahfouz72 requested a review from rnveach August 16, 2025 10:27
@mahfouz72
Copy link
Collaborator Author

Github, generate report for JavadocMissingWhitespaceAfterAsterisk/Example1

@mahfouz72 mahfouz72 mentioned this pull request Aug 16, 2025
Open
@github-actions
Copy link

Report for JavadocMissingWhitespaceAfterAsterisk/Example1:
https://checkstyle-diff-reports-bucket.s3.us-east-1.amazonaws.com/d524ed3315d243e02ef5284d26823ed06797361f_2025112544/reports/diff/index.html

@mahfouz72
Copy link
Collaborator Author

https://checkstyle-diff-reports-bucket.s3.us-east-1.amazonaws.com/d524ed3315d243e02ef5284d26823ed06797361f_2025112544/reports/diff/checkstyle/index.html#A2

Grammar bug

{@code *}

`--JAVADOC_INLINE_TAG -> JAVADOC_INLINE_TAG [0:2]
    `--CODE_INLINE_TAG -> CODE_INLINE_TAG [0:2]
        |--JAVADOC_INLINE_TAG_START -> {@ [0:2]
        |--TAG_NAME -> code [0:4]
        |--LEADING_ASTERISK ->  * [0:8]                                                   This should be text
        `--JAVADOC_INLINE_TAG_END -> } [0:10]

@mahfouz72 mahfouz72 force-pushed the missing-ws-after-asterisk branch from d524ed3 to 19b8889 Compare August 16, 2025 11:53
@mahfouz72
Copy link
Collaborator Author

Github, generate report for JavadocMissingWhitespaceAfterAsterisk/Example1

@github-actions
Copy link

Report for JavadocMissingWhitespaceAfterAsterisk/Example1:
https://checkstyle-diff-reports-bucket.s3.us-east-1.amazonaws.com/19b8889700170edb1a22bc1e6f5f19028ca042af_2025123429/reports/diff/index.html

@mahfouz72
Copy link
Collaborator Author

@nrmancuso please review, all diffs lgtm

@nrmancuso nrmancuso assigned mahfouz72 and unassigned nrmancuso Aug 16, 2025
@mahfouz72 mahfouz72 merged commit 2223ef0 into new-javadoc-grammar Aug 16, 2025
13 checks passed
mahfouz72 added a commit that referenced this pull request Sep 9, 2025
@mahfouz72
Update MissingWhitespaceAfterAsteriskCheck (#64)
17024d4
mahfouz72 added a commit that referenced this pull request Sep 13, 2025
@mahfouz72
Update MissingWhitespaceAfterAsteriskCheck (#64)
ab62b1d
mahfouz72 added a commit that referenced this pull request Sep 16, 2025
@mahfouz72
Update MissingWhitespaceAfterAsteriskCheck (#64)
a5dc758
mahfouz72 added a commit that referenced this pull request Sep 27, 2025
@mahfouz72
Update MissingWhitespaceAfterAsteriskCheck (#64)
7b2d6b3
mahfouz72 added a commit that referenced this pull request Sep 29, 2025
@mahfouz72
Update MissingWhitespaceAfterAsteriskCheck (#64)
7308830
mahfouz72 added a commit that referenced this pull request Oct 3, 2025
@mahfouz72
Update MissingWhitespaceAfterAsteriskCheck (#64)
db13d15
@mahfouz72 mahfouz72 mentioned this pull request Oct 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nrmancuso nrmancuso nrmancuso approved these changes

@rnveach rnveach Awaiting requested review from rnveach

Assignees

@mahfouz72 mahfouz72

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mahfouz72 @nrmancuso