KEMBAR78
Add `--template` for issue and PR by guerinoni · Pull Request #7185 · cli/cli · GitHub
Skip to content

Add --template for issue and PR #7185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 27, 2023
Merged

Add --template for issue and PR #7185

merged 6 commits into from
Mar 27, 2023

Conversation

@guerinoni
Copy link
Contributor

Fixes #1553

Signed-off-by: Federico Guerinoni guerinoni.federico@gmail.com
Co-authored-by: Alessio Cosenza cosenzaalessio17@gmail.com

@guerinoni guerinoni requested a review from a team as a code owner March 16, 2023 17:58
@guerinoni guerinoni requested review from samcoe and removed request for a team March 16, 2023 17:58
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Mar 16, 2023
samcoe
samcoe reviewed Mar 19, 2023
View reviewed changes
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guerinoni Thanks for getting this work started, I am not certain I understand the purpose of the BlankTemplate flag though? Seems to me that it is equivalent of not specifying any template. Could you elaborate a bit on what purpose it serves?

@guerinoni
Copy link
Contributor Author

@guerinoni Thanks for getting this work started, I am not certain I understand the purpose of the BlankTemplate flag though? Seems to me that it is equivalent of not specifying any template. Could you elaborate a bit on what purpose it serves?

I see the proposal of that flag but actually I can remove it and leave as you said without specifying any template :)

@guerinoni @AlessioC31
Add --template for issue and PR
5498d3a 
Fixes cli#1553

Signed-off-by: Federico Guerinoni <guerinoni.federico@gmail.com>
Co-authored-by: Alessio Cosenza <cosenzaalessio17@gmail.com>
@guerinoni guerinoni requested a review from samcoe March 20, 2023 15:20
@samcoe samcoe self-assigned this Mar 22, 2023
@guerinoni
Copy link
Contributor Author

@samcoe Fixed now :)

samcoe
samcoe reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guerinoni Thanks for the contribution! I pushed a small change to simplify some of the logic and reduce the scope of the change just a tad. I still need to add a couple more tests but this looks good to go.

@samcoe samcoe enabled auto-merge (squash) March 27, 2023 08:14
@samcoe samcoe merged commit c6a693c into cli:trunk Mar 27, 2023
@guerinoni guerinoni deleted the template-issue branch March 27, 2023 08:39
@yeikel
Copy link
Contributor

yeikel commented Mar 28, 2023

Hello there,

When are you planning to release this?

Thanks!

jtpetty pushed a commit that referenced this pull request May 22, 2023
@guerinoni @AlessioC31 @jtpetty
Add --template flag for issue create and pr create (#7185)
21250e5 
Signed-off-by: Federico Guerinoni <guerinoni.federico@gmail.com>
Co-authored-by: Alessio Cosenza <cosenzaalessio17@gmail.com>
@andyfeller andyfeller mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@samcoe samcoe samcoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samcoe samcoe

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable specifying which issue template to use when creating

4 participants

@guerinoni @yeikel @samcoe @cliAutomation