This repository was archived by the owner on Oct 19, 2021. It is now read-only.
rerun for #251 (fix for fat arrow positives #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @greenify I forgot to refactor. |
AsaAyers
added a commit
that referenced
this pull request
May 31, 2014
rerun for #251 (fix for fat arrow positives
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also encountered issue #249. @Sinetheta fix works fine for me. Here's a hopefully working pull request.
(only for the missinng_fat_arrow_rule)
As
containsButIsntaborts as soon as it finds a class node, I am not sure whether this really covers all special cases. However all tests run fine.