This repository was archived by the owner on Oct 19, 2021. It is now read-only.
Indent solution #282
Merged
Indent solution #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor change to use 'is' instead of '==' and other similar changes.
…clutchski#236 Finally fixes all the INDENT errors that we have been seeing by now accounting for multiple chains in a chain call
Tests are good
Didn't handle a case where CoffeeScript may generate new tokens into the Lexer, thus returning false when the next token was not '.' even though it was. See first test case added for an example. Second test case written to handle sub multi-chained commands. Not related to described problem above.
|
The new tests look very thorough. I'm extremely impressed. Thanks for your hard work on this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have gone through every single issue both open/closed that complained about indents and I was able to get coffeelint to pass them.
All other tests pass as well, but I would appreciate some additional testing from others.