KEMBAR78
Add the "type" property for each rule closes #178 by DopustimVladimir · Pull Request #179 · coffeelint/coffeelint · GitHub
Skip to content

Conversation

DopustimVladimir
Copy link
Contributor

@DopustimVladimir DopustimVladimir commented Nov 6, 2021

Add the "type" property for each rule

closes #178

@sibiraj-s
Copy link
Member

Code changes looks fine. If would be great to add a test.

Also can it be just style or problem. Thoughts?

@sibiraj-s sibiraj-s requested a review from UziTech November 6, 2021 15:24
Copy link
Member

@sibiraj-s sibiraj-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. just the one minor thing.

Copy link
Member

@sibiraj-s sibiraj-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@sibiraj-s sibiraj-s merged commit 85f38a2 into coffeelint:master Nov 7, 2021
github-actions bot pushed a commit that referenced this pull request Nov 7, 2021
# [5.2.0](v5.1.1...v5.2.0) (2021-11-07)

### Features

* add "type" property to rules ([#179](#179)) ([85f38a2](85f38a2))
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2021

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An idea to split the rules into logical parts

2 participants